[LEDE-DEV] Automated shell code debugging

[Lars Kruse]

Hi,


Am Sat, 1 Oct 2016 00:11:23 +0200
schrieb Martin Tippmann <mt at i3o.de>:

> [..]
> I'm not a shell pro but I found it very difficult to impossible to
> write something that passes without any hints/errors.
> 
> There is a way to avoid this by using special comments that prevent
> shellcheck from nagging about the problem but this would pollute the
> code with shellcheck specific comments.

personally I would appreciate these comments in the rare circumstances were
quoting is not suitable.
For example, currently (before Jan-Tarek's patches) there are a lot of unquoted
variables, where it is not clear, if this is intended or if they were forgotten.
Thus explicit override comments would help clarifying that and keeping the code
(and potential) issues understandable.

Writing shell code is really tricky - I think, we should use all the tools that
are easily available in order to reduce the amount of potential mistakes.


> Maybe using mail for the reports is too spammy due to the shortcomings
> of shellcheck? Something like a generated HTML report[1] on a website
> would be probably good enough/better?

I would appreciate that. I could host this or I could prepare it on lede
infrastructure, if this is what we want.

Cheers,
Lars