[LEDE-DEV] [patch master 07/15] Quote to prevent word splitting

Lars Kruse lists at sumpfralle.de
Fri Sep 30 15:22:20 PDT 2016


Hi Jan-Tarek,


Am Fri, 30 Sep 2016 22:02:21 +0200
schrieb Jan-Tarek Butt <tarek at ring0.de>:

> diff --git a/scripts/strip-kmod.sh b/scripts/strip-kmod.sh
> index ef35b82..2946408 100755
> --- a/scripts/strip-kmod.sh
> +++ b/scripts/strip-kmod.sh
> @@ -50,6 +50,6 @@ $3 && $2 ~ /[brtd]/ && $3 !~ /\$LC/ && !def[$3] {
>  }
>  ' > "$MODULE.tmp1"
>  
> -"${CROSS}"objcopy `cat "${MODULE}".tmp1` "${MODULE}".tmp "${MODULE}".out
> +"${CROSS}"objcopy "`cat "${MODULE}".tmp1`" "${MODULE}".tmp "${MODULE}".out
>  mv "${MODULE}.out" "${MODULE}"
>  rm -f "${MODULE}".t*

here the "tmp1" file seems to contain multiple "--redefine-sym ..." arguments.
Thus it should not be squashed into a single parameter.
I do not see a sane way to add quoting here.

Lars



More information about the Lede-dev mailing list