[LEDE-DEV] [PATCH 2/2] base-files: fix config storing on generation

Felix Fietkau nbd at nbd.name
Fri Sep 30 06:56:26 PDT 2016


On 2016-09-30 15:10, Koen Vandeputte wrote:
> 
> On 2016-09-30 15:00, Felix Fietkau wrote:
>> On 2016-09-30 14:57, Koen Vandeputte wrote:
>>>
>>> On 2016-09-30 14:31, Felix Fietkau wrote:
>>>> On 2016-09-30 09:48, Koen Vandeputte wrote:
>>>>> The general "uci commit" does NOT store the generated sections.
>>>>>
>>>>> Fix this for now by storing each part separately.
>>>> I'd prefer getting the real bug fixed instead of just working around it
>>>> like this.
>>> I totally agree, but the main intent was to have at least some temporary
>>> solution until the real bug is fixed.
>>> Without this temp fix, a device will regenerate the configs on each boot.
>>>
>>> If this consequence is OK for you, then I totally agree with rejection.
>> I've never seen this bug in my own tests so far. What device did you
>> reproduce it on?
> Gateworks laguna (cns3xxx)
> 
> When flashing a fresh image (not sysupgrade), no 'system' config file is 
> present in /etc/config
Also when you use sysupgrade -n?

> So the file gets touched (empty) and the config gets generated as 
> expected (confirmed with 'uci show system')
> 
> However,
> - After the initial generation the 'system' file remains empty (also 
> when executing 'uci commit' manually afterwards)
> - it only gets filled when manually executing 'uci commit system'
I can't reproduce this on my GW2391

- Felix




More information about the Lede-dev mailing list