[LEDE-DEV] [OpenWrt-Devel] openwrt userspace git repo location

[valent.turkovic at gmail.com]

On 28 September 2016 at 10:30, Felix Fietkau <nbd at nbd.name> wrote:
> [Cc'd lede-dev@]
>
> On 2016-09-28 10:03, Luka Perkov wrote:
>> On Wed, Sep 28, 2016 at 08:46:51AM +0200, Felix Fietkau wrote:
>>> On 2016-09-28 00:56, Luka Perkov wrote:
>>> > Hi Felix,
>>> >
>>> > it seems there is some divergence from the Git repos hosted on OpenWrt
>>> > site and on LEDE:
>>> >
>>> > http://git.openwrt.org/?p=project/ubus.git;a=summary
>>> > https://git.lede-project.org/?p=project/ubus.git;a=summary
>>> >
>>> > Do you know why is that?
>>> I don't see the divergence there. Care to explain what you mean?
>>
>> The last two commits were not merged. Thanks for merging them in the
>> meantime.
>>
>> As per earlier discussions on #openwrt-devel with Zoltan, the
>> git.openwrt.org trees should have been mirrored from
>> git.lede-project.org, right?
> I don't know if somebody merged those commits manually or why they
> weren't automatically merged in the first place, maybe there was a
> glitch in the automated mirroring setup.
>
>>> > Speaking of this topic I'd like to propose that we host these repos in a
>>> > single location on GitHub under the OpenWrt project here:
>>> >
>>> > https://github.com/openwrt
>>> >
>>> > GitHub proved to be convinient in attracting easier collaboration. I'm
>>> > wondering what the community thinks about this proposal. Thoughts?
>>> For packages that I maintain, I will stick to git.lede-project.org as
>>> the main repo.
>>>
>>> I still find github to be rather cumbersome, and we already had to add
>>> automatic mirroring of some github repos to git.lede-project.org,
>>> because github was being unreliable again.
>>>
>>> I do see the point in enabling github-style collaboration for the main
>>> repo or for package feeds, but not for things like ubus.
>>
>> Well, the whole workflow like - I have decided XYZ in LEDE and I will
>> now (try to) push it in OpenWrt too just because does not make any
>> sense.
> We added the automatic repository mirroring to make things easier for
> OpenWrt, because upstream development of those components is with LEDE now.
> If OpenWrt guys simply want to contribute to the development of these
> components, feel free to send patches to the LEDE list.
> However, OpenWrt wants to fork any of the component packages like ubus,
> please tell us which ones so we can disable automatic mirroring of them.
> It's completely up to you guys.
>
>> Can you elaborate why you do not see a point in enabeling GitHub
>> style collaboration?
> GitHub lowers the entry barrier by enabling people to contribute that
> aren't able (or willing) to adopt the development workflow of sending
> patches to the mailing list. Even though this has somewhat reduced the
> average quality of contributions in practice and made the maintenance
> work more cumbersome for some of us (including me), that was an
> acceptable tradeoff for increasing number of contributions for the main
> repo and packages.
>
> For me personally, the github workflow is quite annoying, but I'm
> willing to accept it in places where the benefits outweigh the costs.
>
> Components like netifd and ubus need more careful review and testing, so
> to me as a maintainer, lowering the entry barrier does not make any sense.
>
> - Felix
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Github has become de facto standard for contributing to open source
projects, so no matter if you hate it or love it, this is just now the
new norm.
Going against the "norm" is seen by potential contributors as building
barriers for contribution.

I'm not a openwrt developer/contributor so I can't speak from that
angle, but as an hardware and software integrator but I have report
numerous bugs and helped developers to track down issues so that they
can fix it faster...

I have seen patches being rejected on mailing lists and after giving
feedback most patches come back with fixed any outstanding issues.
When more people contribute then handling one-time patches becomes
bigger task, but most contributors on github as on mailing lists will
take their code and comments from maintainers and clean it up or fix
it...

So from my outside point of view having userspace openwrt  parts on
github would be a good move for the project...