[LEDE-DEV] [PATCH v2] [base-files] dont change defaults for vm.min_free_kbytes on devices with <64MiB RAM

Rafał Miłecki zajec5 at gmail.com
Sat Sep 17 22:59:04 PDT 2016


On 16 September 2016 at 19:39, Bastian Bittorf <bb at npl.de> wrote:
> with 5c9cc7b7f8920944a413644e1c2ea23bfe655bcb we changed the default
> value of 'vm.min_free_kbytes' from ~650 to 4096 kilobytes on 32MiB-RAM-devices.
> This makes them hardly useable with a lot of OOM-crashes.
>
> Change that and use 1024 kilobytes for 32MiB-RAM-devices.
> For devices with more than 32MiB RAM we keep the behaviour / the values.
>
> While we are at it, localize vars and read the memory without AWK/nonforking.

Please remember to sign off your changes in the future.


> changes v1 -> v2: (suggestions from Felix Fietkau, Rafał Miłecki)
> - keep -quiet option from sysctl
> - use 1024 kilobyte on 32MiB-devices instead of the kernel default
> - consistently use unit [MiB]

Changelogs should usually go into comments section.


> ---

Right here (comments part).


>  package/base-files/files/etc/init.d/sysctl | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/package/base-files/files/etc/init.d/sysctl b/package/base-files/files/etc/init.d/sysctl
> index a0daec0..7a16e01 100755



More information about the Lede-dev mailing list