[LEDE-DEV] [PATCH 3/3] lantiq: add device tree binding for dwc2 on danube

[Ben Mulvihill]

On Sun, 2016-10-30 at 14:23 +0200, Antti Seppälä wrote:
> On 30 October 2016 at 14:09, Ben Mulvihill <ben.mulvihill at gmail.com> wrote:
> > On Sun, 2016-10-30 at 12:27 +0200, Antti Seppälä wrote:

.......

> >> Could you make another simple test where you temporarily edit the
> >> params_ltq structure to have default values (-1) for all other fields
> >> than the .otg_cap that is set to 2? The .otg_cap is used to disable
> >> OTG power and session negotiation that seems to be required for some
> >> boards.
> >>
> >> The fact that the driver doesn't complain anything about fifo
> >> initialization suggests that the autodetection is working and reason
> >> for non-working usb traffic could be elsewhere. However it is possible
> >> that the autodetection logic is flawed and we need indeed to
> >> initialize fifos with hard-coded values in which case values from
> >> params_ltq are probably "good enough".
> >>
> >
> > Yes, setting -1 for all parameters apart from .otg_cap does works.
> 
> Oh goodie, I guess then a new definition such as params_ltq_danube
> should be introduced?  Autodetected bigger fifos lead to better
> performance.
> 
I'll do that then. I'll just wait to hear what the verdict is on
the name for the binding.

Ben