[LEDE-DEV] [PATCH 3/3] lantiq: add device tree binding for dwc2 on danube

[Ben Mulvihill]

On Fri, 2016-10-28 at 23:35 +0200, Ben Mulvihill wrote:
> On Fri, 2016-10-28 at 19:14 +0300, Antti Seppälä wrote:
> > On 28 October 2016 at 17:30, Ben Mulvihill <ben.mulvihill at gmail.com> wrote:
> > > Add device tree binding for dwc2 usb driver on lantiq danube
> > >
> > > Signed-off-by: Ben Mulvihill <ben.mulvihill at gmail.com>
> > > ---
> > > diff -uprN a/target/linux/lantiq/dts/danube.dtsi b/target/linux/lantiq/dts/danube.dtsi
> > > --- a/target/linux/lantiq/dts/danube.dtsi       2016-10-27 19:56:07.090392399 +0200
> > > +++ b/target/linux/lantiq/dts/danube.dtsi       2016-10-27 20:47:34.387511522 +0200
> > > @@ -140,7 +140,7 @@
> > >                 };
> > >
> > >                 ifxhcd at E101000 {
> > > -                       compatible = "lantiq,ifxhcd-danube";
> > > +                       compatible = "lantiq,ifxhcd-danube", "lantiq,ifxhcd-danube-dwc2";
> > >                         reg = <0xE101000 0x1000
> > >                                 0xE120000 0x3f000>;
> > >                         interrupt-parent = <&icu0>;
> > >
> > >
> > 
> > Hi.
> > 
> > Have you tried if danube can simply be compatible with vanilla "snps,dwc2"?
> > 
> > The main reason we created our own definition for lantiq is that arx
> > and xrx have fifo sizes smaller than what the dwc2 autodetection
> > mechanism expects.
> > I remember finding some references in ifxhcd code which would suggest
> > that danube had bigger fifo and thus would maybe work without any
> > special treatment.
> > 
> > Br,
> 
> I'm pretty sure I tried it, but must have been a couple of years
> ago and I can't remember why it didn't work. I'll have another go.
> 
> Thanks for the suggestion,
> 
> Ben 

You are right. It works fine with "snps,dwc2". (Apart from the same
mode mismatch warnings) When I tried that before I didn't have the
benefit of your hardware initialisation code and my own version
must have been wrong.

I'll submit a version 2 patch set.

Ben