[LEDE-DEV] [RFC 3/6 v2] x86: Add sp5100_tco as a kernel module

[Chris Blake]

On Sun, Oct 23, 2016 at 7:19 AM, Felix Fietkau <nbd at nbd.name> wrote:
> On 2016-10-22 19:39, Chris Blake wrote:
>> This patch enables the kernel sp5100_tco watchdog driver to be built as
>> a kernel module.
>>
>> Signed-off-by: Chris Blake <chrisrblake93 at gmail.com>
>> ---
>>  target/linux/x86/modules.mk | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/target/linux/x86/modules.mk b/target/linux/x86/modules.mk
>> index 1fc5ce5..f6a87ee 100644
>> --- a/target/linux/x86/modules.mk
>> +++ b/target/linux/x86/modules.mk
>> @@ -19,3 +19,18 @@ define KernelPackage/gpio-nct5104d/description
>>  endef
>>
>>  $(eval $(call KernelPackage,gpio-nct5104d))
>> +
>> +define KernelPackage/sp5100_tco
>> +  SUBMENU:=$(OTHER_MENU)
>> +  TITLE:=SP5100 Watchdog Support
>> +  DEPENDS:=@TARGET_x86
>> +  KCONFIG:=CONFIG_SP5100_TCO
>> +  FILES:=$(LINUX_DIR)/drivers/watchdog/sp5100_tco.ko
>> +  AUTOLOAD:=$(call AutoLoad,50,sp5100_tco,1)
>> +endef
>> +
>> +define KernelPackage/sp5100_tco/description
>> + Kernel module for the SP5100_TCO hardware watchdog.
>> +endef
> Please enable this in the x86/64 kernel config instead of packaging it.
>
> - Felix
>

Felix,

If possible, can sp5100_tco be kept as a kmod? The justifiable reason
is that if a user wants to use the I2c interface on the board, this
driver needs to be unloaded as it can't be used along side the i2c
interface. Keeping this a kmod will allow users to do this without
needing to modify the build. More info is at
https://github.com/riptidewave93/LEDE-APU2/issues/9 and
https://github.com/riptidewave93/LEDE-APU2/pull/5#issuecomment-255667736

Regards,
Chris Blake