[LEDE-DEV] [PATCHv2] ipq806x: add support for ZyXEL NBG6817

[Felix Fietkau]

Hi André,

On 2016-10-19 20:58, Andre Valentin wrote:
> Hi Felix!
> 
> Am 19.10.2016 um 12:40 schrieb Felix Fietkau:
>> On 2016-10-18 09:49, André Valentin wrote:
>>> Hi John,
>>>
>>> thanks for your comments. Please take a look:
>>>
>>> Am 18.10.2016 um 08:22 schrieb John Crispin:
>>>
>>>>> +++ b/target/linux/ipq806x/base-files/lib/preinit/04_set_mtd_ipq806x.sh
>>>>> @@ -0,0 +1,21 @@
>>>>> +#
>>>>> +# Copyright (C) 2009 OpenWrt.org
>>>>> +#
>>>>> +
>>>>> +. /lib/ipq806x.sh
>>>>> +. /lib/functions/system.sh
>>>>> +
>>>>> +preinit_assign_mtd2block() {
>>>>> +	case $(ipq806x_board_name) in
>>>>> +		nbg6817)
>>>>> +			echo "/dev/mmcblk0p2,64KiB,romd" > /sys/module/block2mtd/parameters/block2mtd
>>>>> +			echo "/dev/mmcblk0p3,64KiB,header" > /sys/module/block2mtd/parameters/block2mtd
>>>>> +			echo "/dev/mmcblk0p4,64KiB,kernel" > /sys/module/block2mtd/parameters/block2mtd
>>>>> +			echo "/dev/mmcblk0p6,64KiB,header_1" > /sys/module/block2mtd/parameters/block2mtd
>>>>> +			echo "/dev/mmcblk0p7,64KiB,kernel_1" > /sys/module/block2mtd/parameters/block2mtd
>>>>> +			echo "/dev/mmcblk0p8,64KiB,rootfs_1" > /sys/module/block2mtd/parameters/block2mtd
>>>>> +			;;
>>>>> +	esac
>>>>> +}
>>>>> +
>>>>
>>>> can this not go into the commandline inside the devicetree ?
>>> I tried, but block2mtd accepts only one mapping in the command line.
>>>
>>> I will rework the patch the next days and send an update.
>> Why do we need block2mtd at all for this target?
> 
> The system uses an internal mmc for storage of root fs and other data. I saw that the rb532 platform also uses block2mtd for this.
> With ubi on top of it, everything including sysupgrade worked nearly out of the box. That's why I preferred to use existing parts.
> If you have another idea, please tell. For me it's my first mmc based platform.
MMC is just a block device like any other. Please take a look at octeon,
mvebu or x86 as examples of how to do it without block2mtd.

Thanks,

- Felix