[LEDE-DEV] [PATCH v3 3/4] base-files, mac80211, broadcom-wl: wifi detection and configuration

[Felix Fietkau]

On 2016-10-17 15:59, Christian Lamparter wrote:
> Currently, the wifi detection script is executed as part of
> the (early) boot process. Pluggable wifi USB devices, which
> are inserted at a later time are not automatically
> detected and therefore they don't show up in LuCI.
> 
> A user has to deal with wifi detection manually, or restart
> the router.
> 
> However, the current "sleep 1" window - which the boot
> process waits for wifi devices to "settle down" - is too
> short to detect wifi devices for some routers anyway.
> 
> For example, this can happen with USB WLAN devices on the
> WNDR4700. This is because the usb controller needs to load
> its firmware from UBI and initialize, before it can operate.
> 
> The issue can be seen on a BT HomeHub 5A as well as soon as
> the caldata are on an ubi volume. This is because the ath9k
> card has to be initialized by owl-loader first. Which has to
> wait for the firmware extraction script to retrieve the pci
> initialization values inside the caldata.
> 
> This patch moves the wifi configuration to hotplug scripts.
> For mac80211, the wifi configuration will now automatically
> run any time a "ieee80211" device is added. Likewise
> broadcom-wl's script checks for new "net" devices which
> have the "wl$NUMBER" moniker.
> 
> Issues with spawning multiple interface configuration - in
> case the detection script is run concurrently - have been
> resolved by using a named section for the initial
> configuration. Concurrent configuration scripts will now
> simply overwrite the same existing configuration.
> 
> A workaround which preserves the "sleep 1" window for just
> the first boot has been added. This allows the existing
> brcm47xx boot and mvebu uci-default scripts to correctly
> setup the initial mac addresses and regulatory domain.
> 
> And finally, the patch renames the "wifi detect" into
> "wifi config". As the script no longer produces any output
> that has to be redirected or appended to the configuration
> file.
> 
> Thanks to Martin Blumenstingl for helping with the implementation
> and testing of the patch.
> 
> Acked-by: Jo-Philipp Wich <jo at mein.io>
> Signed-off-by: Mathias Kresin <dev at kresin.me>
> Signed-off-by: Christian Lamparter <chunkeey at gmail.com>
Added to my staging tree with a small modification:
I added a check for detect and made it no-op, just in case existing user
scripts still use it, because the default case might trigger some
unwanted actions.

- Felix