[LEDE-DEV] [RFC 0/3] Proposal to change to default tagged switch configurations

Jo-Philipp Wich jo at mein.io
Sat Oct 15 16:43:10 PDT 2016

This is a patch series which attempts to change uci-defaults to always generate
switch configurations with tagged CPU ports, even if only one VLAN is present
on the switch.

When facing a default untagged configuration, a user has to do the following
steps in order to add an additional port based VLAN:

 - Change the existing VLANs CPU port from untagged to tagged
 - Change the existing LAN or WAN ifname from ethX to ethX.Y notation
 - Apply the switch settings and regain connectivity
 - Actually add the new VLAN

The first three steps require careful coordination and frequently lead to
soft-bricks when not done in proper order or not committed atomically to the

By emitting tagged switch configurations by default, the configuration of
additional port based VLANs is drastically simplified from a users perspective.

The series is split into three patches:

Patch #1 introduces a new syntax which allows boards to opt-out of the default
tagging, which is useful for boards with weird switch settings or known broken
VLAN support.

Patch #2 converts the current implicit untagged boards of brcm63xx to explicit
untagging as several brcm63xx switches are known to have quirks.

Patch #3 finally switches the default behaviour from untagged to tagged switch

The series is not intended to be applied as-is but rather for facilitating
additional feedback regarding potential switch quirks on further targets or

~ Jo

Jo-Philipp Wich (3):
  base-files: uci-defaults: support requesting untagged switch port
  brcm63xx: board.d: request untagged switch config where applicable
  base-files: emit tagged switch configuration by default

 .../base-files/files/lib/functions/uci-defaults.sh | 24 ++++++++++++++--------
 .../brcm63xx/base-files/etc/board.d/02_network     |  4 ++--
 2 files changed, 17 insertions(+), 11 deletions(-)


More information about the Lede-dev mailing list