[LEDE-DEV] [PATCH] busybox: prevent globbing, word splitting

Jan-Tarek Butt tarek at ring0.de
Fri Oct 14 11:32:22 PDT 2016


Double quote to prevent globbing and word splitting.

Signed-off-by: Jan-Tarek Butt <tarek at ring0.de>
---
 package/utils/busybox/files/cron | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/utils/busybox/files/cron b/package/utils/busybox/files/cron
index 19ecc43..a201374 100755
--- a/package/utils/busybox/files/cron
+++ b/package/utils/busybox/files/cron
@@ -14,7 +14,7 @@ validate_cron_section() {
 start_service () {
 	[ -z "$(ls /etc/crontabs/)" ] && return 1
 
-	loglevel=$(uci_get "system. at system[0].cronloglevel")
+	loglevel="$(uci_get "system. at system[0].cronloglevel")"
 
 	[ -z "${loglevel}" ] || {
 		/sbin/validate_data uinteger "${loglevel}" 2>/dev/null
@@ -28,7 +28,7 @@ start_service () {
 	ln -s /etc/crontabs /var/spool/cron/ 2>/dev/null
 
 	procd_open_instance
-	procd_set_param command "$PROG" -f -c /etc/crontabs -l ${loglevel:-5}
+	procd_set_param command "$PROG" -f -c /etc/crontabs -l "${loglevel:-5}"
 	procd_close_instance
 }
 
-- 
2.10.0




More information about the Lede-dev mailing list