[LEDE-DEV] [PATCH v2] uboot-envtools: remove function vals and fix indentation

Oswald Buddenhagen oswald.buddenhagen at gmx.de
Thu Oct 6 14:15:06 PDT 2016


this commit message is cryptic; i had to read the patch to understand
what you mean. there seems to be a pattern. ;)

also, technically speaking, you're not _fixing_ the indentation, as it
was canonical. you're using a less known shell feature to _improve_ it.
(fwiw, i dislike that the syntax _requires_ tabs. that's ok in this
script, as it uses tabs anyway, but it's limiting.)




More information about the Lede-dev mailing list