[LEDE-DEV] [PATCH 1/2] generic: ar8216: fix ar8xxx_is_possible check

John Crispin john at phrozen.org
Mon Oct 3 22:46:51 PDT 2016



On 03/10/2016 22:57, Christian Lamparter wrote:
>> > why do you want to remove this check ? imho it does no harm
> The C-60 doesn't have a PHY at 3. This caused the check in ar8xxx_is_possible
> to fail and the ethernet ports on the C-60. Also, it doesn't look like the
> qca8k.c (DSA) driver checks for it. So I removed it.

your patch failed to mention this. remving the code because of a buggy
switch seems odd. please modify the code to just skip missing phy ids.

	John



More information about the Lede-dev mailing list