[LEDE-DEV] [PATCH][uclient] uclient-http: send correct "Host:" header if port is not the default

Alexander Couzens lynxis at fe80.eu
Wed Nov 30 09:04:46 PST 2016


On Wed, 30 Nov 2016 18:02:53 +0100
Felix Fietkau <nbd at nbd.name> wrote:

> On 2016-11-30 17:49, Alexander Couzens wrote:
>  [...]  
> I think the comparison against the default port is unnecessary, just
> include the port if it was provided as part of the URL.
> I also don't like the duplication of the ustream_printf line.
> How about:
> "Host: %s%s%s" ...
> url->port ? ":" : "",
> url->port ? url->port : "",
looks better.

best,
lynxis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/lede-dev/attachments/20161130/e82f2cb8/attachment.sig>


More information about the Lede-dev mailing list