[LEDE-DEV] LED naming convention

[Jonas Gorski]

Hi,

On 16 November 2016 at 08:21,  <p.wassi at gmx.at> wrote:
> Hi,
>
> as I've been working on changes for kirkwood/board.d/01_leds:
>
> Previously, for ar71xx or ramips, I've been told to name LEDs like
> <boardname>:<color>:<function> (1)
> before that, they were
> <manufacturer>:<color>:<function> (2)
> (And we also renamed those of (2) in order to fit (1))
>
> On target kirkwood, some LEDs are named by upstream kernel DTS files.
> E.g. arch/arm/boot/dts/kirkwood-dockstar.dts names the Dockstar's LEDs
> status:green:health and status:orange:fault

The kernel led naming rules are described in [1]:
> LED Device Naming
> =================
>
> Is currently of the form:
>
> "devicename:colour:function"

so the Dockstar's led names are in violation of that. At least
"status" does not seem to be a sensible device name.

> When I look at other boards, which have their LEDs named by upstream kernel, I see
> that even in kernel this is not consistent.
> Is it acceptable to patch kernel-dts through our local quilt in order to match (1)?
> Maybe this would be accepted upstream too, since it's currently not consistent.

Upstream first, then patch it locally as well.


Regards
Jonas

[1] http://lxr.free-electrons.com/source/Documentation/leds/leds-class.txt