[LEDE-DEV] [RFC 01/12] ath25: generalize button hotplug

Karl Palsson karlp at tweak.net.au
Tue May 31 08:12:31 PDT 2016


As discussed on irc, I don't really see any need to keep this.  People can just insert scripts directly into /etc/hotplug.d/button, rather than _still_ entering UCI system buttons configs?  

Jo-Philipp Wich <jo at mein.io> wrote:
> The ath25 target has its own unique button action config
> support, make it available to all targets by moving it from
> ath25 to base-files.
> 
> Signed-off-by: Jo-Philipp Wich <jo at mein.io>
> 
>  create mode 100644 package/base-files/files/etc/hotplug.d/button/00-button
>  delete mode 100644 target/linux/ath25/base-files/etc/hotplug.d/button/00-button
> 
> diff --git
> a/package/base-files/files/etc/hotplug.d/button/00-button
> b/package/base-files/files/etc/hotplug.d/button/00-button new
> file mode 100644 index 0000000..63cc217
> --- /dev/null
> +++ b/package/base-files/files/etc/hotplug.d/button/00-button
> @@ -0,0 +1,24 @@
> +. /lib/functions.sh
> +do_button () {
> +	local button
> +	local action
> +	local handler
> +	local min
> +	local max
> +
> +	config_get button $1 button
> +	config_get action $1 action
> +	config_get handler $1 handler
> +	config_get min $1 min
> +	config_get max $1 max
> +	
> +	[ "$ACTION" = "$action" -a "$BUTTON" = "$button" -a -n "$handler" ] && {
> +		[ -z "$min" -o -z "$max" ] && eval $handler 
> +		[ -n "$min" -a -n "$max" ] && {
> +			[ $min -le $SEEN -a $max -ge $SEEN ] && eval $handler 
> +		}
> +	}
> +}
> +
> +config_load system
> +config_foreach do_button button
> diff --git
> a/target/linux/ath25/base-files/etc/hotplug.d/button/00-button
> b/target/linux/ath25/base-files/etc/hotplug.d/button/00-button
> deleted file mode 100644 index 63cc217..0000000
> --- a/target/linux/ath25/base-files/etc/hotplug.d/button/00-button
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -. /lib/functions.sh
> -do_button () {
> -	local button
> -	local action
> -	local handler
> -	local min
> -	local max
> -
> -	config_get button $1 button
> -	config_get action $1 action
> -	config_get handler $1 handler
> -	config_get min $1 min
> -	config_get max $1 max
> -	
> -	[ "$ACTION" = "$action" -a "$BUTTON" = "$button" -a -n "$handler" ] && {
> -		[ -z "$min" -o -z "$max" ] && eval $handler 
> -		[ -n "$min" -a -n "$max" ] && {
> -			[ $min -le $SEEN -a $max -ge $SEEN ] && eval $handler 
> -		}
> -	}
> -}
> -
> -config_load system
> -config_foreach do_button button
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP Digital Signature
URL: <http://lists.infradead.org/pipermail/lede-dev/attachments/20160531/074673d3/attachment.sig>


More information about the Lede-dev mailing list