[LEDE-DEV] Missing signed-off-by

[Kevin Darbyshire-Bryant]

On 19/05/16 08:48, John Crispin wrote:
>
>
> On 19/05/2016 09:39, Kevin Darbyshire-Bryant wrote:
>> Hi Etienne (& list)
>>
>> Yes I've just noticed that too when I looked at them coming back at me
>> via master.  I feel really bad!
>>
>> I will submit a new PR with properly signed commits once I've done this
>> email.  I guess reverting the unsigned & applying the signed would
>> maintain an obvious history.
>>
>> Kevin
>>
>> On 19/05/16 08:08, Etienne Champetier wrote:
>>> Hi,
>>>
>>> Just noticed that 2 commits (dnsmasq.time related) are missing SOB line.
>>> Kevin can you confirm that you sign off the 2 commits?
>>> http://developercertificate.org/
>>>
>>> Cheers
>>> Etienne
>>>
>

New signed off pull request https://github.com/lede-project/source/pull/39

>
> darn they are in source.git already. we should maybe add a commit hook
> to not accept patches that do not have a SoB in them

The mistake got past two humans.....they're obviously the weak link :-)

Kevin