[LEDE-DEV] [PATCH 2/4] [RFC] fstools: block.c: Add support for checking vfat filesystems

Jo-Philipp Wich jo at mein.io
Wed May 18 04:15:57 PDT 2016


Hi,

>>> +    if (!strncmp(pr->id->name, "vfat", 4)) {

"If fs name starts with vfat ..."

>>> +        ckfs = e2fsck;

"... then use the ext4 checker".

>>> +    } else if (!strncmp(pr->id->name, "ext", 3)) {

"... else if fs name starts with ext ..."

>>> +        ckfs = dosfsck;

"... then use the dosfs checker".

>> Is this the wrong way round?
> 
> Do you mean you mean you think ext should be tested first?

That certainly looks swapped to me as well.

~ Jo



More information about the Lede-dev mailing list