[LEDE-DEV] [PATCH 2/2] [ubox] logd: add ubus reload method

[Karl Palsson]

Alexandru Ardelean <ardeleanalex at gmail.com> wrote:
> On Thu, May 12, 2016 at 5:30 PM, Karl Palsson
> <karlp at tweak.net.au> wrote:
> 
> >
> > Dan Bugnar <danutbug at gmail.com> wrote:
> > > From: Dan Bugnar <danutbug at gmail.com>
> > >
> > > Add logd link to uci library, to read the system config file
> > > and get the buffer size. Remove the -S option support and use
> > > just the option from the config file.
> >
> >
> > Why do you need this exactly? It's already being parsed from the
> > config file by the init script, and that is much less code than
> > adding all of uci parsing into logd?
> >
> >
> Doing a reload on logd (to increase the buffer size), should
> not clear out the previous log info. By default logd's reload,
> is a logd restart. The end game is to do a proper reload, and
> keep whatever info was logged, before the reload (if doing a
> log buffer increase).

And that's something that you want to do, at run time, often
enough that you want to add config file parsing to it? I mean,
ok, I understand what you're saying, but is that really a useful
usecase? changing log size dynamically?

Cheers,
Karl P
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP Digital Signature
URL: <http://lists.infradead.org/pipermail/lede-dev/attachments/20160512/4f6585b7/attachment.sig>