[LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

[Bert Vermeulen]

On 05/07/2016 08:11 PM, Russell Senior wrote:
> In this particular case, as the author of the patch involved, I would
> suggest "if it isn't broken, don't fix it".  That is, iftop doesn't
> really need ncursesw, the patch lets it use plain ncurses even if
> ncursesw is available.  I don't see the problem leaving things like
> that.  It means carrying a small patch.  Seems like not that big a
> problem.

Carrying patches is of course a problem: as I showed with numbers, a
problem that won't solve itself and will get worse over time.

Upstreaming your patch must clearly be the first choice. Did you even
try to upstream an ncurses preference in iftop? It's been in the OpenWrt
repo for 3.5 YEARS!


-- 
Bert Vermeulen
bert at biot.com