[LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

[Felix Fietkau]

On 2016-05-07 12:40, Bert Vermeulen wrote:
> On 05/07/2016 12:01 PM, Felix Fietkau wrote:
>> On 2016-05-07 11:43, Bert Vermeulen wrote:
>>> Is there anything else that could pull in libncursesw?
>> Packages from feeds sometimes use libncursesw instead of libncurses. I
>> just did a size comparison:
>> 110481 libncurses_5.9-3_mipsel_1004kc_dsp.ipk
>> 125871 libncursesw_5.9-3_mipsel_1004kc_dsp.ipk
>>
>> I think the difference in size is not big enough to justify having two
>> separate packages to choose from via dependencies.
>>
>> We should probably just move everything to libncursesw and drop
>> libncurses entirely.
> 
> Actually I'd gotten this wrong: libncursesw is an extra build option to 
> libncurses, so you only get it if you explicitly want it. In that case 
> though, you specifically DO want your applications to use ncursesw instead 
> of regular ncurses.
It's a build variant, meaning both can be built and staged at the same time.

> So regardless of whether you keep libncurses around or not, I think patches 
> preferring one or the other should be dropped, right?
What the package ends up using absolutely needs to match the
dependencies that the package specifies (otherwise you get a build
error). Allowing the package source build system to simply pick one will
result in very quirky behavior.

- Felix