[LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

Felix Fietkau nbd at nbd.name
Sat May 7 03:01:20 PDT 2016


On 2016-05-07 11:43, Bert Vermeulen wrote:
> On 05/07/2016 07:17 AM, John Crispin wrote:
>> 
>> 
>> On 05/05/2016 15:16, Bert Vermeulen wrote:
>>> The patch made sure the ncursesw library was not selected to save space,
>>> but that library doesn't exist in this distribution at all.
>> 
>> are you sure that ncursesw is not inside any of the feeds either ?
> 
> It's not clear to me what are considered "official" feeds, i.e. which
> should be checked for dependencies and this sort of thing.
> 
> Going by the uncommented ones in feeds.conf.default, I find four
> references to ncursesw: two patches to avoid compiling against it (i.e.
> same as iftop), and two that weirdly _prefer_ it over ncurses. It seems
> to me all of those can go.
> 
> Is there anything else that could pull in libncursesw?
Packages from feeds sometimes use libncursesw instead of libncurses. I
just did a size comparison:
110481 libncurses_5.9-3_mipsel_1004kc_dsp.ipk
125871 libncursesw_5.9-3_mipsel_1004kc_dsp.ipk

I think the difference in size is not big enough to justify having two
separate packages to choose from via dependencies.

We should probably just move everything to libncursesw and drop
libncurses entirely.

- Felix



More information about the Lede-dev mailing list