[LEDE-DEV] [PATCH] lantiq: fix network in failsafe

[Mathias Kresin]

Am 20.06.2016 um 05:15 schrieb Zhao, Gang:
> Hi, Mathias Kresin
>
> On Sun, Jun 19, 2016 at 10:30 PM, Mathias Kresin <dev at kresin.me> wrote:
>> So far the network in failsafe is setup only for one board. Use the
>> eth0 interface as lan interface for all boards for now.
>>
>> If a board has its lan interface(s) on another eth, a special
>> handling based on the board name can be added.
>>
>> Signed-off-by: Mathias Kresin <dev at kresin.me>
>> ---
>>   .../lantiq/base-files/lib/preinit/05_set_preinit_iface_lantiq  | 10 +---------
>>   1 file changed, 1 insertion(+), 9 deletions(-)
>>
>> diff --git a/target/linux/lantiq/base-files/lib/preinit/05_set_preinit_iface_lantiq b/target/linux/lantiq/base-files/lib/preinit/05_set_preinit_iface_lantiq
>> index 3d7fabf..7ed0fab 100644
>> --- a/target/linux/lantiq/base-files/lib/preinit/05_set_preinit_iface_lantiq
>> +++ b/target/linux/lantiq/base-files/lib/preinit/05_set_preinit_iface_lantiq
>> @@ -3,15 +3,7 @@
>>   . /lib/functions/lantiq.sh
>>
>>   set_preinit_iface() {
>> -
>> -       board=$(lantiq_board_name)
>> -
>> -       case "$board" in
>> -       TDW8970)
>> -               ifname=eth0
>> -               ;;
>> -       esac
>> -
>> +       ifname=eth0
>
> What about to add a default branch in case statement?
>
> *)
>      ifname=eth0
> ;;

Adding a default branch doesn't make any sense to me as long as the only 
value set in the default branch is the same as the one in the only 
conditional.

I had changed the case statement to only consists of a default case, to 
make obvious how to add a different config for a specific board. But in 
the end I dropped the whole case since it was just unused code.