[LEDE-DEV] [PATCH uclient] enable --post-file, use "Content-Length" instead of chunked encoding

Felix Fietkau nbd at nbd.name
Fri Jun 17 08:31:50 PDT 2016


On 2016-06-17 13:19, xinglp wrote:
> --post-file parameter only support text file not binary file.
> "Content-Length" is more compatible to the http server world.
Your patch cannot apply due to whitespace damage. Also, the library
supports delivering POST data in multiple calls to send_data - your
patch is breaking that completely.
If you want to support using content_length instead of chunked encoding,
please do so in an optional way that does not break the existing code.
Could you please also provide some information why you're replacing
chunked encoding with content-length? What servers do not accept this?
And why are you saying it "only support text file not binary file"?

- Felix




More information about the Lede-dev mailing list