[LEDE-DEV] [PATCH mountd 2/4] fix crash if no uci config file present

John Crispin john at phrozen.org
Wed Jun 15 09:58:07 PDT 2016



On 15/06/2016 18:07, Conor O'Gorman wrote:
> On 15/06/16 15:10, olivier.hardouin at gmail.com wrote:
>> fix also possible null dereferenced pointers
>>
>> Signed-off-by: Olivier Hardouin <olivier.hardouin at gmail.com>
>> ---
>>   uci.c  | 6 ++++++
>>   ucix.c | 9 ++++++++-
>>   2 files changed, 14 insertions(+), 1 deletion(-)
>>
> The code design appears to be that uci_init() is called before any
> others. It initialises p.
> I would argue for a runtime warning and fail rather than a silent return
> for these errors?
> 

not worth the effort, i plan to rewrite this as part of the block tool
and nuke mountd.

	John



More information about the Lede-dev mailing list