[LEDE-DEV] [PATCH 2/2] Add script to build common platforms.

[Ben Greear]

On 06/03/2016 09:19 AM, Karl Palsson wrote:
>
>> Maybe some of it, but for more generic platforms, I am not sure
>> sub-targets make sense, and in general, it is more difficult to
>> edit those than to change a diffconfig as far as I can tell.
>
> For who?  I'm pretty sure I can use "make menuconfig" _far_ more reliably than I can edit a diffconfig file to use a "buildme" script.  If I don't know anything, and _need_ to build a custom image that can't be built with image builder, or post install config, then menuconfig at least makes sure that dependencies get pulled in properly.  Adding line items to file that you then "defoncfig" and hope you got perfectt seems fraught with danger, and for what? To avoid showing someone how to use menuconfig?  Which they'll need to use anyway?  Because I don't believe for a _second_ that somehow you're going to have "buildme" magic that automatically solves all the configs someone needs.

First of all, any time you try to add a new module, someone will bitch about
how it bloats their beautiful image and makes it impure.  Adding more sub-targets
almost cannot by definition be any less likely to rot or be un-maintained than
the buildme targets I am proposing.

To create (or update) the diffconfig, you can run menuconfig, twiddle as you like, and then save the
new diffconfig.  And commit changes (assuming you are maintaining this buildme profile).

If the diffconfig profiles are really that un-cool, then maybe just add the buildme
script with ability to use URL for the diffconfig profile and let folks host them
elsewhere.  That is less user-friendly (it would be hard to show user all available options),
but at least it is still one command to build an image.

And anyway, no one is proposing to remove menuconfig logic, I just want to add some
wrappers to make it easier for newbies that may initially be bewildered by all of the menuconfig
options (and lack of options if you haven't installed the proper feeds already).

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com