[LEDE-DEV] [PATCH 2/2] Add script to build common platforms.

Ben Greear greearb at candelatech.com
Wed Jun 1 11:21:05 PDT 2016


On 06/01/2016 11:07 AM, John Crispin wrote:
> Hi Ben,
>
> also inclined to reject this one. it will open up the pandoras box and
> we will end up maintaining piles of diffconfig files. it would make
> morse sense to document what the script does inside web.git as a "how to
> build" or "getting started" page

I do not have much history with LEDE/WRT, but is the diffconfig output
really that fragile?

I will be willing to maintain the x86-64 and probably Ventana
diffconfigs, and even if it totally fails, you have not lost
any functionality since the main infrastructure is unchanged.

I think I could further improve the buildme.sh to automatically
pull in the feeds based on the packages in the diffconfig too,
which should further automate building and make the buildme.sh
more generic for different platforms.

For jow's idea, putting it in a web page may be better than nothing,
but then it just means anyone wanting to use this type of thing
has more work to do, and for newbies, that can be all the difference
between success and failure.

I still think you should consider letting this patch in.  I can
re-do it based on removing the 1/2 patch, so the diffconfig gets
bigger, but we can still build usable apu2 images out of the box.

Either way, thanks for considering the patch.

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com




More information about the Lede-dev mailing list