[LEDE-DEV] [PATCH] _GNU_SOURCE should be defined for building vs uClibc

[Waldemar Brodkorb]

Hi Karl,
Karl Palsson wrote,

> 
> John Crispin <john at phrozen.org> wrote:
> > 
> > 
> > On 23/05/2016 20:12, Waldemar Brodkorb wrote:
> > > Hi John,
> > > John Crispin wrote,
> > > 
> > >> Hi,
> > >> is it really a gnu extension or is uclibc b0rked for these symbols ?
> > > 
> > > I think it isn't b0rked.
> > > It was added for ARM GNU libc here under #ifdef __USE_GNU:
> > > https://sourceware.org/git/?p=glibc.git;a=blobdiff;f=sysdeps/unix/sysv/linux/arm/bits/fcntl.h;h=aa2d36ca80f0ca4c5793b28b3852ce60b5fe57ef;hp=6a5f89ad1f8bdf8a825fc1e55a84679a86349a6c;hb=adb252daea96e7e160553703d477b76ff6a7781e;hpb=01b5049d107460f5eca797eda983958d1a410ffd
> > > 
> > > And later moved to generic fcntl.h file. So we are correct here or
> > > at least compatible to GNU libc.
> > > 
> > > best regards
> > >  Waldemar
> > >  
> > 
> > ok, i'll merge it later today or in the morning
> > 
> 
> This still doesn't work on the uclibc in openwrt-CC branch. The
> O_PATH definitions are in asm-generic/fcntl.h, which can be
> included via linux/fcntl.h, _GNU_SOURCE doesn't get this pulled
> in though.
> 
> I attempted to add includes for linux/fcntl, but it just gives me
> redeclaration errors for struct flock.

The definition where added to uClibc-ng after 1.0.9 release.
LEDE included 1.0.14 recently. You need to update.

best regards
 Waldemar