[LEDE-DEV] ledtrig-usbdev

[e9hack]

Hi,

something seems to be wrong with this two commits:

kernel: remove obsolete patch adding usb_find_device_by_name
ledtrig-usbdev: use upstream function for iterating USB devices

If a TP-Link WDR3600 or Archer-C7 router boots with a connected USB stick, this error does
occur:

[   43.572609] ------------[ cut here ]------------
[   43.577458] WARNING: CPU: 0 PID: 2227 at drivers/leds/ledtrig-usbdev.c:94 0x8721f424()
[   43.585527] Modules linked in: ath9k ath9k_common pppoe ppp_async iptable_nat ath9k_hw
ath pppox ppp_generic pl2303 nf_nat_ipv4 nf_conntrack_ipv6 nf_conntrack_ipv4 mac80211
ipt_REJECT ipt_MASQUERADE ftdi_sio cp210x cfg80211 zlib_inflate zlib_deflate xt_time
xt_tcpudp xt_tcpmss xt_string xt_statistic xt_state xt_recent xt_nat xt_multiport xt_mark
xt_mac xt_limit xt_length xt_iprange xt_id xt_hl xt_helper xt_ecn xt_dscp xt_conntrack
xt_connmark xt_connlimit xt_connbytes xt_comment xt_TCPMSS xt_REDIRECT xt_NFQUEUE xt_NFLOG
xt_NETMAP xt_LOG xt_IPMARK xt_HL xt_DSCP xt_CT xt_CLASSIFY vhci_hcd usbserial usbip_host
usbip_core ums_usbat ums_sddr55 ums_sddr09 ums_karma ums_jumpshot ums_isd200 ums_freecom
ums_datafab ums_cypress ums_alauda ts_kmp ts_fsm ts_bm slhc nfnetlink_queue nfnetlink_log
nf_reject_ipv4 nf_nat_rtsp nf_nat_redirect nf_nat_masquerade_ipv4 nf_nat nf_log_ipv4
nf_defrag_ipv6 nf_defrag_ipv4 nf_conntrack_rtsp nf_conntrack_rtcache nf_conntrack_netlink
iptable_raw iptable_mangle iptable_filter ipt_ECN ip_tables crc_ccitt compat_xtables
compat act_connmark nf_conntrack act_skbedit act_mirred em_u32 cls_u32 cls_tcindex
cls_flow cls_route cls_fw sch_hfsc sch_ingress ledtrig_usbdev xt_set ip_set_list_set
ip_set_hash_netiface ip_set_hash_netport ip_set_hash_netnet ip_set_hash_net
ip_set_hash_netportnet ip_set_hash_mac ip_set_hash_ipportnet ip_set_hash_ipportip
ip_set_hash_ipport ip_set_hash_ipmark ip_set_hash_ip ip_set_bitmap_port
ip_set_bitmap_ipmac ip_set_bitmap_ip ip_set nfnetlink ip6t_rt ip6t_frag ip6t_hbh
ip6t_eui64 ip6t_mh ip6t_ah ip6t_ipv6header ip6t_REJECT nf_reject_ipv6 nf_log_ipv6
nf_log_common ip6table_raw ip6table_mangle ip6table_filter ip6_tables x_tables msdos ifb
tun vfat fat nls_utf8 nls_iso8859_2 nls_iso8859_15 nls_iso8859_1 nls_cp852 nls_cp850
nls_cp437 usb_storage uhci_hcd ohci_platform ohci_hcd ehci_platform ehci_hcd sd_mod
scsi_mod gpio_button_hotplug ext4 jbd2 mbcache exfat usbcore nls_base usb_common crc16
crc32c_generic crypto_hash
[   43.763174] CPU: 0 PID: 2227 Comm: S96led Not tainted 4.4.15 #4
[   43.769252] Stack : 00000000 00000000 80436542 00000033 0000011f 00000000 00000001 803e0000
          803d0000 803d0d43 803800b0 000008b3 80433788 86841b8c 00854530 77711e94
          00000000 800a6fb8 80385cc8 803d0000 00000003 86841b8c 803841b4 86a0fcbc
          80433788 800a4f54 57922a83 00000000 00000001 80430000 00000000 00000000
          00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
          ...
[   43.805710] Call Trace:
[   43.808242] [<80071ff4>] show_stack+0x84/0xb4
[   43.812684] [<800817bc>] warn_slowpath_common+0xa0/0xd0
[   43.818024] [<800818c0>] warn_slowpath_null+0x18/0x24
[   43.823191] [<8721f424>] 0x8721f424
[   43.826759]
[   43.828275] ---[ end trace ed62fc5f1082d690 ]---

If the the WDR3600 boots without the USB stick and I connect it later, this error doesn't
occur (not tested with the Archer-C7).

Regards,
Hartmut