[LEDE-DEV] Do we really need 000-keep_initrafs_the_default.patch?

[Felix Fietkau]

On 2016-07-22 10:58, Alexey Brodkin wrote:
> Hello,
> 
> I'm wondering why there's a need for "000-keep_initrafs_the_default.patch"?
> It could be found here:
> ---------------------->8--------------------
> target/linux/generic/patches-3.18/000-keep_initrafs_the_default.patch
> target/linux/generic/patches-4.1/000-keep_initrafs_the_default.patch
> target/linux/generic/patches-4.4/000-keep_initrafs_the_default.patch
> ---------------------->8--------------------
> 
> With that patch in place for initramfs no additional options are reported
> for "/" partition. What's really important is missing info about sizes.
> Which in its turn makes opkg think that there's no space on "/" partition
> to install software.
> 
> I understand that's a sort of corner-case, people rarely install packages on
> ramfs but anyways why not?
> 
> Just in case that's what I see with the patch:
> ---------------------->8--------------------
> root at lede:/# cat /proc/mounts
> rootfs / rootfs rw 0 0
> proc /proc proc rw,nosuid,nodev,noexec,noatime 0 0
> sysfs /sys sysfs rw,nosuid,nodev,noexec,noatime 0 0
> tmpfs /tmp tmpfs rw,nosuid,nodev,noatime 0 0
> tmpfs /dev tmpfs rw,nosuid,relatime,size=512k,mode=755 0 0
> devpts /dev/pts devpts rw,nosuid,noexec,relatime,mode=600 0 0
> debugfs /sys/kernel/debug debugfs rw,noatime 0 0
> ---------------------->8--------------------
> 
> And without:
> ---------------------->8--------------------
> root at lede:/# cat /proc/mounts
> rootfs / rootfs rw,size=256168k,nr_inodes=32021 0 0
> proc /proc proc rw,nosuid,nodev,noexec,noatime 0 0
> sysfs /sys sysfs rw,nosuid,nodev,noexec,noatime 0 0
> tmpfs /tmp tmpfs rw,nosuid,nodev,noatime 0 0
> tmpfs /dev tmpfs rw,nosuid,relatime,size=512k,mode=755 0 0
> devpts /dev/pts devpts rw,nosuid,noexec,relatime,mode=600 0 0
> debugfs /sys/kernel/debug debugfs rw,noatime 0 0
> ---------------------->8--------------------
> 
> Note how different is entry for rootfs.
> 
> If there're no objections I'll go ahead and send a patch that
> gets rid of all 3 patches mentioned above.
No objections from me. I looked at the commit that added this patch for
the first time, and it does not explain the reason for making this
change at all.

- Felix