[LEDE-DEV] [PATCH v2 2/8] apm821xx: add support for the Cisco Meraki MR24

[Christian Lamparter]

On Thursday, July 14, 2016 6:39:34 PM CEST Felix Fietkau wrote:
> On 2016-07-13 21:23, Christian Lamparter wrote:
> > From: Chris Blake <chrisrblake93 at gmail.com>
> > 
> > This patch adds support for the Cisco Meraki MR24 Access point
> > to the apm821xx target.
> > 
> > Board:		MR24 - Meraki MR24 Cloud Managed Access Point
> > CPU:		APM82181 SoC 800 MHz (PLB=200 OPB=100 EBC=100)
> > Flash size:	32MiB
> > RAM Size:	128MiB
> > Wireless:	Atheros AR9380 5.0GHz + Atheros AR9380 2.4GHz
> > Ethernet ports:	1x Gigabit Atheros AR8035
> > 
> > WARNING: The serial port needs a TTL/RS-232 v3.3 level converter!
> > 
> > For flashing instructions, visit:
> > <https://github.com/riptidewave93/Openwrt-MR24/blob/master/README.md#flashing>
> > 
> > Signed-off-by: Chris Blake <chrisrblake93 at gmail.com>
> > ---
> >  target/linux/apm821xx/Makefile                     |   1 +
> >  .../linux/apm821xx/base-files/etc/board.d/01_leds  |   8 +
> >  .../apm821xx/base-files/etc/board.d/02_network     |   3 +
> >  target/linux/apm821xx/base-files/etc/diag.sh       |   4 +
> >  target/linux/apm821xx/base-files/lib/apm821xx.sh   |   4 +
> >  .../lib/preinit/05_set_iface_mac_apm821xx          |  14 +
> >  .../apm821xx/base-files/lib/upgrade/merakinand.sh  |  65 ++++
> >  .../apm821xx/base-files/lib/upgrade/platform.sh    |   9 +
> >  target/linux/apm821xx/cisco/config-default         |  15 +
> >  target/linux/apm821xx/cisco/target.mk              |  11 +
> >  target/linux/apm821xx/config-4.4                   |   1 +
> >  target/linux/apm821xx/dts/MR24.dts                 | 433 +++++++++++++++++++++
> >  target/linux/apm821xx/image/Makefile               |  81 +++-
> >  .../002-powerpc_ibm_phy_add_ar8035.patch           |  62 +++
> >  .../200-add-meraki-mr24-ikarem-support.patch       |  31 ++
> >  tools/firmware-utils/src/mkmerakifw.c              |  10 +
> >  16 files changed, 742 insertions(+), 10 deletions(-)
> >  create mode 100644 target/linux/apm821xx/base-files/lib/preinit/05_set_iface_mac_apm821xx
> >  create mode 100755 target/linux/apm821xx/base-files/lib/upgrade/merakinand.sh
> >  create mode 100644 target/linux/apm821xx/cisco/config-default
> >  create mode 100644 target/linux/apm821xx/cisco/target.mk
> >  create mode 100644 target/linux/apm821xx/dts/MR24.dts
> >  create mode 100644 target/linux/apm821xx/patches-4.4/002-powerpc_ibm_phy_add_ar8035.patch
> >  create mode 100644 target/linux/apm821xx/patches-4.4/200-add-meraki-mr24-ikarem-support.patch
> > 
> > diff --git a/target/linux/apm821xx/Makefile b/target/linux/apm821xx/Makefile
> > index ba3b179..809f2f1 100644
> > --- a/target/linux/apm821xx/Makefile
> > +++ b/target/linux/apm821xx/Makefile
> > @@ -11,6 +11,7 @@ CPU_TYPE:=464fp
> >  FEATURES:=fpu dt gpio
> >  MAINTAINER:=Chris Blake <chrisrblake93 at gmail.com>, \
> >  	    Christian Lamparter <chunkeey at gmail.com>
> > +SUBTARGETS:=cisco
> >  
> >  KERNEL_PATCHVER:=4.4
> >  
> Having one subtarget per device is overkill. Is there any reason why you
> cannot support all devices from the same target without having
> subtargets at all?
This is mostly because with subtargets, it's possible to have different
kernel configs.

MyBook Live is somewhat unique compared to the MR24 or the WNDR4700. It has to
do without any flash (the 512Kb flash on the MBL only contains the u-boot). 
The target's boot and rootfs has to be located on the SATA drive, so the MBL
needs to have the ext2/4 built-in to boot. (WD's u-boot requires the bootfs 
to be ext2. We could do without it, if we didn't care about sysupgrade).

The problem with having a shared target for MR24 and WNDR4700 is that the they
have different hard-coded addresses (CONFIG_PPC_EARLY_DEBUG_44x_PHYSLOW) for 
the early console. Other than that, there is AFICT no reason.

So, what's the plan? Have a NAS and ROUTER subtarget? And forget about the early
console?