[LEDE-DEV] Concerning the switch to dwc2 on Danube

[Hauke Mehrtens]

On 12/28/2016 09:41 PM, Ben Mulvihill wrote:
> On Wed, 2016-12-28 at 19:26 +0000, Mohammed Berdai wrote:
>> Hi,
>>
>> I managed to test the latest LEDE commits after missing daily tests for a few weeks due to a busy schedule.
>>
>> The switch to dwc2 module caused kernel panics on ARV4518pw, ARV7518pw and ARV7510pw22.
>>
>> I tracked LEDE git repo till I reached these:
>>
>> lantiq: use dwc2 by default on danube
>> ffd7c155008bff4b08197dfd710d7a1386313f98
>>
>> lantiq: dwc2 parameters for danube
>> 6f60926babe50cd1aa24fb849577fff9fe7f46b4
>>
>> lantiq: device tree bindings for dwc2 on danube
>> 5c06a31e23b9cc1b8c8a1a8e0ab58353fc925865
>>
>> lantiq: initialise dwc2 on danube
>> c82d5b30e10e6987bb73119c2c08ec9ff4a504dd 
>>
>> When I reverted them all three routers went back to normal.
>>
>> I reported this issue with bootlogs here:
>>
>> https://bugs.lede-project.org/index.php?do=details&task_id=350
>>
>> https://bugs.lede-project.org/index.php?do=details&task_id=351
>>
>> It would be great if we can resolve this issue before LEDE first stable release.
>>
>> I can help you doing tests and report back to you.
>>
>> Regards,
>>
>> Mohammed
> 
> Oh dear! Sorry about that.
> 
> I've put the Lede mailing list on copy.
> 
> It looks from the boot logs as though the dwc2 driver does
> not handle the gpio request correctly. I tested my changes
> on a BTHOMEHUBV2B which does not request a specific gpio.
> Your Arcadian boards do.
> 
> As a quick fix it should be enough to revert commit 
> ffd7c155008bff4b08197dfd710d7a1386313f98
> (lantiq: use dwc2 by default on danube)
> without reverting the other two. That way the old driver is
> used by default but dwc2 is still available for those boards
> where it does work.
> 
> If time is too short to sort out the gpio problem before the
> freeze for the first stable release I could do a patch to
> make dwc2 the default on the BTHOMEHUBV2B only, leaving the
> old driver as the default on the other danube boards.

Hi,

I reverted the commit which changes the default USB2 driver in my
staging tree, can you please try if the images build from my staging
tree works:
https://git.lede-project.org/?p=lede/hauke/staging.git;a=summary
We want to do the release soon so it would be nice to have this fixed
before. The real fix will probably be done later.

John suggested that some Danube boards have similar problems as some
ramips boards and these patches could fix the problem with dwc2:

https://git.lede-project.org/?p=source.git;a=blob;f=target/linux/ramips/patches-4.4/0032-USB-dwc2-add-device_reset.patch;h=e77e02f6772ef775dffa616e74b5684f50abb05a;hb=HEAD

https://git.lede-project.org/?p=source.git;a=blob;f=target/linux/ramips/patches-4.4/0069-awake-rt305x-dwc2-controller.patch;h=cef05ad53db9e3140366b437d91e7e8dffbc8ba7;hb=HEAD

Hauke