[LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

Florian Fainelli f.fainelli at gmail.com
Tue Dec 27 12:00:08 PST 2016


On 12/27/2016 11:32 AM, Christian Schoenebeck wrote:
> Do you really think this is a good idea ?
> If base-files package is not selected, the postinst-pkg and prerm-pkg of none of the other selected packages will be called.
> It's nice to suppress error messages but to switch off all postinst and prerm defined inside Makefile of any selected package in not really a good idea.

base-files can be deselected (and it should remain that way), in which
case you cannot complete an OpenWrt build because we stop with the
errors mentioned below, fixing that alone has value IMHO.

It seems reasonable to expect that nothing in your system that relies on
base-files can be working, the use case for a system without base-files
can be: a) replacement of the full OpenWrt/LEDE user-space with
something custom, b) build testing/combination coverage (how this was
caught here), c) minimal system getting you to a prompt without starting
anything.
-- 
Florian



More information about the Lede-dev mailing list