[LEDE-DEV] [PATCH] kernel: drop superflous b43 patch

[Jonas Gorski]

On 21 December 2016 at 10:42, John Crispin <john at phrozen.org> wrote:
>
>
> On 21/12/2016 09:39, Jonas Gorski wrote:
>> On 21 December 2016 at 09:34, John Crispin <john at phrozen.org> wrote:
>>>
>>>
>>> On 21/12/2016 09:31, Jonas Gorski wrote:
>>>> Hi,
>>>>
>>>> On 21 December 2016 at 09:21, John Crispin <john at phrozen.org> wrote:
>>>>> This patch makes 3 symbols default, that get selected by the according code.
>>>>>
>>>>> arch/mips/bcm47xx/Kconfig:      select SSB_B43_PCI_BRIDGE if PCI
>>>>> drivers/net/wireless/broadcom/b43legacy/Kconfig:        select SSB_B43_PCI_BRIDGE
>>>>> drivers/net/wireless/broadcom/b43/Kconfig:      select SSB_B43_PCI_BRIDGE
>>>>> drivers/net/wireless/broadcom/b43/Kconfig:      select SSB_BLOCKIO
>>>>> drivers/ssb/Kconfig:config SSB_BLOCKIO
>>>>> drivers/net/wireless/broadcom/b43/Kconfig:      select BCMA_BLOCKIO
>>>>
>>>> Except that we don't ever enable b43 within the kernel, so they would
>>>> then stay unselected.
>>>>
>>>> So NAK ;p
>>>>
>>>> Regards
>>>> Jonas
>>>>
>>>
>>> ok, so this is a hack patch not applicable for usptream or will you send
>>> it upstream so that we can drop it ?
>>
>> This is only required if you build ssb/bcma from the kernel, but build
>> b43 from kernel-backports (which can't affect the kernel config).
>> Since bcm47xx/bcm53xx requires ssb/bcma built-in into the kernel we
>> can't just build ssb/bcma from backports either.
>>
>> So a hack patch not suitable for upstream, and rather specific for our use case.
>>
>>
>> Jonas
>
> Ok, so this is a requirement when building a kernel with a newer
> compat-wireless driver. imho we could simply give the bools a prompt
> instead of setting the default to y and then expalin that this is needed
> when building compat-wireless drivers. i think this should be fine for
> upstream ?

Usually if you do that you would also just build ssb/bcma from
compat-wireless as well. Building ssb/bcma from the kernel itself will
also require you to patch the in-kernel drivers to the ones matching
the compat-wireless release (more or less), so it really isn't just
allowing these to be set to y manually for that.


Jonas