[LEDE-DEV] [PATCH] kernel: drop superflous b43 patch

Jonas Gorski jonas.gorski at gmail.com
Wed Dec 21 00:39:00 PST 2016


On 21 December 2016 at 09:34, John Crispin <john at phrozen.org> wrote:
>
>
> On 21/12/2016 09:31, Jonas Gorski wrote:
>> Hi,
>>
>> On 21 December 2016 at 09:21, John Crispin <john at phrozen.org> wrote:
>>> This patch makes 3 symbols default, that get selected by the according code.
>>>
>>> arch/mips/bcm47xx/Kconfig:      select SSB_B43_PCI_BRIDGE if PCI
>>> drivers/net/wireless/broadcom/b43legacy/Kconfig:        select SSB_B43_PCI_BRIDGE
>>> drivers/net/wireless/broadcom/b43/Kconfig:      select SSB_B43_PCI_BRIDGE
>>> drivers/net/wireless/broadcom/b43/Kconfig:      select SSB_BLOCKIO
>>> drivers/ssb/Kconfig:config SSB_BLOCKIO
>>> drivers/net/wireless/broadcom/b43/Kconfig:      select BCMA_BLOCKIO
>>
>> Except that we don't ever enable b43 within the kernel, so they would
>> then stay unselected.
>>
>> So NAK ;p
>>
>> Regards
>> Jonas
>>
>
> ok, so this is a hack patch not applicable for usptream or will you send
> it upstream so that we can drop it ?

This is only required if you build ssb/bcma from the kernel, but build
b43 from kernel-backports (which can't affect the kernel config).
Since bcm47xx/bcm53xx requires ssb/bcma built-in into the kernel we
can't just build ssb/bcma from backports either.

So a hack patch not suitable for upstream, and rather specific for our use case.


Jonas



More information about the Lede-dev mailing list