[LEDE-DEV] rt5350-spi rt2880-spi question

[Giuseppe Lippolis]

In the driver code is written the follow comment:

        /*
         * spidev should never be referenced in DT without a specific
         * compatible string, it is a Linux implementation thing
         * rather than a description of the hardware.
         */

What shall I use in the .dts to bind a generic spi driver?


> -----Ursprüngliche Nachricht-----
> Von: Giuseppe Lippolis [mailto:giu.lippolis at gmail.com]
> Gesendet: Samstag, 10. Dezember 2016 23:21
> An: lede-dev at lists.infradead.org
> Betreff: rt5350-spi rt2880-spi question
> 
> I have an update.
> Using the following add to the DWR-512-B.dts
> 
> &spi1 {
>         status = "okay";
> 
>         spidev at 1 {
>                 #address-cells = <1>;
>                 #size-cells = <1>;
>                 compatible = "spidev";
>                 reg = <0>;
>                 spi-max-frequency = <30000000>;
>         };
> };
> 
> I'm able to see the device:
> root at lede:/tmp# ls /dev/spi*
> /dev/spidev1.0
> 
> But in the bootlog I get:
> 
> [   56.306119] procd: - init -
> [   56.902341] ip6_tables: (C) 2000-2006 Netfilter Core Team
> [   56.944417] i2c /dev entries driver
> [   56.965816] Loading modules backported from Linux version
> wt-2016-10-03-1-g6fcb1a6
> [   56.981067] Backport generated by backports.git
> backports-20160324-9-g0e38f5c
> [   57.003743] ip_tables: (C) 2000-2006 Netfilter Core Team
> [   57.034967] nf_conntrack version 0.5.0 (447 buckets, 1788 max)
> [   57.084989] spidev spi1.0: buggy DT: spidev listed directly in DT
> [   57.097291] ------------[ cut here ]------------
> [   57.106611] WARNING: CPU: 0 PID: 415 at drivers/spi/spidev.c:719
> init_module+0x333c/0x3dec [spidev]()
> [   57.125042] Modules linked in: spidev(+) slhc nf_reject_ipv4
> nf_nat_redirect nf_nat_masquerade_ipv4 nf_nat nf_log_ipv4
> nf_defrag_ipv6
> nf_defrag_ipv4 nf_conntrack_rtcache nf_conntrack iptable_raw
> iptable_mangle iptable_filter ip_tables crc_itu_t crc_ccitt compat
i2c_ralink
> i2c_dev i2c_core ip6t_REJECT nf_reject_ipv6 nf_log_ipv6 nf_log_common
> ip6table_raw ip6table_mangle ip6table_filter ip6_tables x_tables
> eeprom_93cx6 leds_gpio ehci_platform ehci_hcd gpio_button_hotplug
> usbcore nls_base usb_common
> [   57.213233] CPU: 0 PID: 415 Comm: kmodloader Not tainted 4.4.36 #0
> [   57.225597] Stack : 80325d94 00000000 00000001 80360000 819aaa80
> 80362d23
> 803076cc 0000019f
> [   57.225597] 	  803a3430 00000007 0000001a 024000c0 80065a9c
8004a6c8
> 8030cbe4 80360000
> [   57.225597] 	  00000003 00000007 8030afe8 81bf3b4c 80065a9c
80048634
> 00000000 00000000
> [   57.225597] 	  00000001 00000000 00000000 00000000 00000000
00000000
> 00000000 00000000
> [   57.225597] 	  00000000 00000000 00000000 00000000 00000000
00000000
> 00000000 00000000
> [   57.225597] 	  ...
> [   57.296770] Call Trace:
> [   57.301757] [<80065a9c>] module_sect_show+0x0/0x18
> [   57.311382] [<8004a6c8>] vprintk_default+0x24/0x30
> [   57.321003] [<80065a9c>] module_sect_show+0x0/0x18
> [   57.330619] [<80048634>] printk+0x2c/0x38
> [   57.338626] [<80024f44>] warn_slowpath_common+0xa0/0xd0
> [   57.349107] [<80148d38>] dump_stack+0x14/0x28
> [   57.357871] [<8001442c>] show_stack+0x50/0x84
> [   57.366623] [<80024f44>] warn_slowpath_common+0xa0/0xd0
> [   57.377117] [<80d8633c>] init_module+0x333c/0x3dec [spidev]
> [   57.388288] [<80d80000>] 0x80d80000
> [   57.395318] [<80024ffc>] warn_slowpath_null+0x18/0x24
> [   57.405459] [<801bebd0>] of_match_node+0x20/0x44
> [   57.414739] [<80d80000>] 0x80d80000
> [   57.421771] [<80d8633c>] init_module+0x333c/0x3dec [spidev]
> [   57.432971] [<801964a8>] devm_kfree+0x20/0x44
> [   57.441752] [<801ad3f4>] spi_drv_probe+0x3c/0x84
> [   57.451019] [<80192e7c>] driver_probe_device+0x120/0x288
> [   57.461695] [<80089984>] kstrdup+0x44/0x8c
> [   57.469923] [<801ad2f4>] spi_match_device+0x38/0xa8
> [   57.479733] [<80193060>] __driver_attach+0x7c/0xb4
> [   57.489291] [<80191284>] next_device+0x10/0x30
> [   57.498221] [<80192fe4>] __driver_attach+0x0/0xb4
> [   57.507665] [<80191340>] bus_for_each_dev+0x9c/0xac
> [   57.517469] [<802b3ca8>] klist_add_tail+0x24/0x50
> [   57.526910] [<80d80000>] 0x80d80000
> [   57.533925] [<80191114>] bus_get+0x2c/0x50
> [   57.542171] [<80192574>] bus_add_driver+0xec/0x20c
> [   57.551796] [<800ac068>] exact_match+0x0/0x8
> [   57.560352] [<800ac570>] exact_lock+0x0/0x24
> [   57.568869] [<80d80000>] 0x80d80000
> [   57.575875] [<80d80000>] 0x80d80000
> [   57.582898] [<80193778>] driver_register+0xa8/0xf8
> [   57.592523] [<80d83000>] init_module+0x0/0xdc [spidev]
> [   57.602838] [<80d80000>] 0x80d80000
> [   57.609852] [<80d80000>] 0x80d80000
> [   57.616809] [<80d80000>] 0x80d80000
> [   57.623828] [<80d83098>] init_module+0x98/0xdc [spidev]
> [   57.634314] [<80154908>] kasprintf+0x1c/0x28
> [   57.642923] [<80045050>] __wake_up+0x24/0x48
> [   57.651510] [<80d83000>] init_module+0x0/0xdc [spidev]
> [   57.661847] [<8000d5c8>] do_one_initcall+0x1e8/0x214
> [   57.671828] [<80045050>] __wake_up+0x24/0x48
> [   57.680395] [<80d83000>] init_module+0x0/0xdc [spidev]
> [   57.690718] [<80033d08>] call_usermodehelper_exec+0x144/0x160
> [   57.702249] [<800337f8>] call_usermodehelper_setup+0x38/0xa8
> [   57.713650] [<80066cbc>] do_init_module+0x74/0x1cc
> [   57.723282] [<8009d4b4>] __vunmap+0xf0/0x114
> [   57.731887] [<80068550>] load_module+0x16c0/0x1b68
> [   57.741516] [<80066088>] unknown_module_param_cb+0x0/0xac
> [   57.752352] [<8009d9a8>] __vmalloc_node+0x34/0x40
> [   57.761817] [<80068a8c>] SyS_init_module+0x94/0x180
> [   57.771617] [<80068b28>] SyS_init_module+0x130/0x180
> [   57.781609] [<8000655c>] syscall_common+0x30/0x54
> [   57.791062] [<800a7e84>] SyS_open+0x0/0x14
> [   57.799227]
> [   57.802242] ---[ end trace de8d23e6a78b367e ]---
> 
> I'm making something wrong?
> Bye.