[LEDE-DEV] [PATCH RFC 2/3] openvpn: use proper quoting of push option in openvpn.config

[Magnus Kroken]

OpenVPN requires arguments to --push to be enclosed in double quotes.
A single set of quotes is stripped when the UCI config is parsed.
Enclosing in double and single quotes results in a proper configuration.

This does not cause errors in OpenVPN 2.3, but OpenVPN 2.4 fails to start
with unquoted push arguments.

This fixes FS#290 by way of documentation, but existing configurations
will need editing to work with OpenVPN 2.4.

Signed-off-by: Magnus Kroken <mkroken at gmail.com>
---
 package/network/services/openvpn/files/openvpn.config | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/package/network/services/openvpn/files/openvpn.config b/package/network/services/openvpn/files/openvpn.config
index 3e053c3..73c1abe 100644
--- a/package/network/services/openvpn/files/openvpn.config
+++ b/package/network/services/openvpn/files/openvpn.config
@@ -117,8 +117,8 @@ config openvpn sample_server
 	# to know to route the OpenVPN client
 	# address pool (10.8.0.0/255.255.255.0)
 	# back to the OpenVPN server.
-#	list push "route 192.168.10.0 255.255.255.0"
-#	list push "route 192.168.20.0 255.255.255.0"
+#	list push '"route 192.168.10.0 255.255.255.0"'
+#	list push '"route 192.168.20.0 255.255.255.0"'
 
 	# To assign specific IP addresses to specific
 	# clients or if a connecting client has a private
@@ -175,14 +175,14 @@ config openvpn sample_server
 	# client's local DHCP server is reachable via
 	# a more specific route than the default route
 	# of 0.0.0.0/0.0.0.0.
-#	list push "redirect-gateway"
+#	list push '"redirect-gateway"'
 
 	# Certain Windows-specific network settings
 	# can be pushed to clients, such as DNS
 	# or WINS server addresses.  CAVEAT:
 	# http://openvpn.net/faq.html#dhcpcaveats
-#	list push "dhcp-option DNS 10.8.0.1"
-#	list push "dhcp-option WINS 10.8.0.1"
+#	list push '"dhcp-option DNS 10.8.0.1"'
+#	list push '"dhcp-option WINS 10.8.0.1"'
 
 	# Uncomment this directive to allow different
 	# clients to be able to "see" each other.
-- 
2.1.4