[LEDE-DEV] [PATCH 1/3] brcm63xx: fix Livebox 1 support: DTS

[Jonas Gorski]

Hi Daniel,

On 16 August 2016 at 13:47, Daniel Gonzalez Cabanelas <dgcbueu at gmail.com> wrote:
> Fix the DTS file for the Livebox 1 routers:
> - leds are totally wrong, fix them.
> - no failsafe button, use button 1 for this purpose
> - part probe wrong, it should be RedBoot (uppercase matters)

These are still three different things, please split it accordingly.


> Signed-off-by: Daniel Gonzalez Cabanelas <dgcbueu at gmail.com>
> diff --git a/target/linux/brcm63xx/dts/livebox-blue-5g.dts b/target/linux/brcm63xx/dts/livebox-blue-5g.dts
> index 0df5fa8..6eeba69 100644
> --- a/target/linux/brcm63xx/dts/livebox-blue-5g.dts
> +++ b/target/linux/brcm63xx/dts/livebox-blue-5g.dts
> @@ -23,7 +23,7 @@
>                 button1 {

Please update the node name as well.

>                         label = "BTN_1";
>                         gpios = <&gpio1 4 1>;
> -                       linux,code = <BTN_1>;
> +                       linux,code = <KEY_RESTART>;
>                 };
>
>                 button2 {
> @@ -37,28 +37,28 @@
>                 compatible = "gpio-leds";
>
>                 red_adsl_fail {
> -                       label = "Livebox-blue-5g:red:adsl-fail";
> +                       label = "Livebox1:red:adsl-fail-power";
>                         gpios = <&gpio0 0 0>;
>                         default-state = "on";
>                 };
>
>                 red_adsl {
> -                       label = "Livebox-blue-5g:red:adsl-fail";
> +                       label = "Livebox1:red:adsl";
>                         gpios = <&gpio0 1 0>;
>                 };
>
>                 red_traffic {
> -                       label = "Livebox-blue-5g:red:adsl-fail";
> +                       label = "Livebox1:red:traffic";
>                         gpios = <&gpio0 2 0>;
>                 };
>
>                 red_phone {
> -                       label = "Livebox-blue-5g:red:adsl-fail";
> +                       label = "Livebox1:red:phone";
>                         gpios = <&gpio0 3 0>;
>                 };
>
>                 red_wifi {
> -                       label = "Livebox-blue-5g:red:adsl-fail";
> +                       label = "Livebox1:red:wifi";
>                         gpios = <&gpio0 4 0>;

Oops, looks like a clear c&p fail by me.

>                 };
>         };
> @@ -68,5 +68,5 @@
>         reg = <0x1e400000 0x800000>;
>         status = "ok";
>
> -       linux,part-probe = "redboot";
> +       linux,part-probe = "RedBoot";
>  };


Regards
Jonas