[LEDE-DEV] [PATCH] Set ATH9K_STATION_STATISTICS when enabling ath9k debugging

Toke Høiland-Jørgensen toke at toke.dk
Tue Aug 23 03:35:26 PDT 2016


Toke Høiland-Jørgensen <toke at toke.dk> writes:

> Felix Fietkau <nbd at nbd.name> writes:
>
>> On 2016-08-23 11:55, Toke Høiland-Jørgensen wrote:
>>>>> diff --git a/target/linux/generic/config-4.4 b/target/linux/generic/config-4.4
>>>>> index 8c30017..2f12982 100644
>>>>> --- a/target/linux/generic/config-4.4
>>>>> +++ b/target/linux/generic/config-4.4
>>>>> @@ -276,6 +276,7 @@ CONFIG_ATA_SFF=y
>>>>>  # CONFIG_ATH9K is not set
>>>>>  # CONFIG_ATH9K_HTC is not set
>>>>>  # CONFIG_ATH_DEBUG is not set
>>>>> +# CONFIG_ATH9K_STATION_STATISTICS is not set
>>>> This change is completely useless, ath9k is never enabled in the kernel
>>>> config.
>>> 
>>> No, but if it's not in there, the mac80211 build disables it when
>>> running `make allnoconfig` even if the Makefile sets it. Unless I've
>>> missed some other way to prevent that?
>> Aside from some generated bits, the mac80211 .config has nothing to do
>> with the kernel config. Also, since the kernel build calls make
>> oldconfig, this option will never actually end up being in the kernel
>> dir .config at all. Simply leave it out and it'll work just fine.
>
> Well, it didn't when I tried. The generated .config had it in there, but
> after running `make allnoconfig` it disappeared. I can go test again,
> but I spent quite a while tearing my hair out before coming up with this
> solution...

OK, just tried again. Seems you're right; must've been removing the
kernel build dir while testing this that fixed things, not the actual
change. Will send a v2 :)

-Toke



More information about the Lede-dev mailing list