[LEDE-DEV] [PATCH] Set ATH9K_STATION_STATISTICS when enabling ath9k debugging

Toke Høiland-Jørgensen toke at toke.dk
Tue Aug 23 02:55:49 PDT 2016


Felix Fietkau <nbd at nbd.name> writes:

> On 2016-08-13 12:02, Toke Høiland-Jørgensen wrote:
>> The ATH9K_STATION_STATISTICS kernel config variable enables some extra
>> statistics that are useful for debugging (in particular with the airtime
>> fairness patches enabled). This adds that kernel config when selecting
>> ath9k debugging.
>> 
>> Signed-off-by: Toke Høiland-Jørgensen <toke at toke.dk>
> Missing "ath9k: " prefix in the subject.

Noted.

>> ---
>>  package/kernel/mac80211/Makefile | 2 +-
>>  target/linux/generic/config-4.4  | 1 +
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/package/kernel/mac80211/Makefile b/package/kernel/mac80211/Makefile
>> index f2839cd..5c0ca3f 100644
>> --- a/package/kernel/mac80211/Makefile
>> +++ b/package/kernel/mac80211/Makefile
>> @@ -1494,7 +1494,7 @@ config-$(call config_package,lib80211) += LIB80211 LIB80211_CRYPT_WEP LIB80211_C
>>  config-$(call config_package,airo) += AIRO
>>  
>>  config-$(call config_package,ath) += ATH_CARDS ATH_COMMON
>> -config-$(CONFIG_PACKAGE_ATH_DEBUG) += ATH_DEBUG ATH10K_DEBUG
>> +config-$(CONFIG_PACKAGE_ATH_DEBUG) += ATH_DEBUG ATH10K_DEBUG ATH9K_STATION_STATISTICS
>>  config-$(CONFIG_PACKAGE_ATH_DFS) += ATH9K_DFS_CERTIFIED ATH10K_DFS_CERTIFIED
>>  
>>  config-$(call config_package,ath9k) += ATH9K
>> diff --git a/target/linux/generic/config-4.4 b/target/linux/generic/config-4.4
>> index 8c30017..2f12982 100644
>> --- a/target/linux/generic/config-4.4
>> +++ b/target/linux/generic/config-4.4
>> @@ -276,6 +276,7 @@ CONFIG_ATA_SFF=y
>>  # CONFIG_ATH9K is not set
>>  # CONFIG_ATH9K_HTC is not set
>>  # CONFIG_ATH_DEBUG is not set
>> +# CONFIG_ATH9K_STATION_STATISTICS is not set
> This change is completely useless, ath9k is never enabled in the kernel
> config.

No, but if it's not in there, the mac80211 build disables it when
running `make allnoconfig` even if the Makefile sets it. Unless I've
missed some other way to prevent that?

-Toke



More information about the Lede-dev mailing list