[openwrt/openwrt] realtek: pcs: drop legacy comment and warning

LEDE Commits lede-commits at lists.infradead.org
Sun Jan 11 02:13:15 PST 2026


robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/f47453863fb575c5337be1b6fb0eb690bf157e46

commit f47453863fb575c5337be1b6fb0eb690bf157e46
Author: Jonas Jelonek <jelonek.jonas at gmail.com>
AuthorDate: Fri Jan 9 23:12:36 2026 +0000

    realtek: pcs: drop legacy comment and warning
    
    We finally reached the point where PCS has full control over SerDes and
    no parts of this are scattered in other drivers anymore. To make that
    clear, drop the comment in pcs_config that explains this former state
    and remove a warning which states that pcs_config isn't fully
    implemented yet.
    
    Add a generic output to at least keep a generic sign of life from the
    PCS driver, independently from what the variant-specific code currently
    prints.
    
    Signed-off-by: Jonas Jelonek <jelonek.jonas at gmail.com>
    Link: https://github.com/openwrt/openwrt/pull/21481
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c b/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
index da7a16d5d7..e6128e64e1 100644
--- a/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
+++ b/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
@@ -3456,14 +3456,8 @@ static int rtpcs_pcs_config(struct phylink_pcs *pcs, unsigned int neg_mode,
 	struct rtpcs_ctrl *ctrl = link->ctrl;
 	int ret = 0;
 
-	/*
-	 * TODO: This (or copies of this) will be the central function for configuring the
-	 * link between PHY and SerDes. As of now a lot of the code is scattered throughout
-	 * all the other Realtek drivers. Maybe some day this will live up to the expectations.
-	 */
-
-	dev_warn(ctrl->dev, "pcs_config(%s) for port %d and sds %d not yet fully implemented\n",
-		 phy_modes(interface), link->port, link->sds->id);
+	dev_info(ctrl->dev, "configure SerDes %u for mode %s\n", link->sds->id,
+		 phy_modes(interface));
 
 	mutex_lock(&ctrl->lock);
 




More information about the lede-commits mailing list