[openwrt/openwrt] treewide: add explicit default variant part 2

LEDE Commits lede-commits at lists.infradead.org
Sun Jan 4 02:25:15 PST 2026


robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/ded99c2984b245ee3885bdf10bd1797e838abf54

commit ded99c2984b245ee3885bdf10bd1797e838abf54
Author: Eric Fahlgren <ericfahlgren at gmail.com>
AuthorDate: Sat Jan 3 16:04:51 2026 -0800

    treewide: add explicit default variant part 2
    
    Add 'DEFAULT_VARIANT' to two packages, 'iw' and 'eapol-test',
    that were missed in the first pass.  Refactor 'iw' and 'ethtool'
    package definitions to be consistent with the pattern used in most
    other packages.
    
    Fixes: https://github.com/openwrt/openwrt/commit/f4fdb996
    Fixes: https://github.com/openwrt/openwrt/commit/7a78dc4a
    Signed-off-by: Eric Fahlgren <ericfahlgren at gmail.com>
    Link: https://github.com/openwrt/openwrt/pull/21380
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 package/network/services/hostapd/Makefile |  1 +
 package/network/utils/ethtool/Makefile    | 11 ++++++-----
 package/network/utils/iw/Makefile         |  9 +++++++--
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/package/network/services/hostapd/Makefile b/package/network/services/hostapd/Makefile
index de24064160..d46be1c6cb 100644
--- a/package/network/services/hostapd/Makefile
+++ b/package/network/services/hostapd/Makefile
@@ -544,6 +544,7 @@ define Package/eapol-test
   $(call Package/eapol-test/Default,$(1))
   TITLE+= (built-in full)
   VARIANT:=supplicant-full-internal
+  DEFAULT_VARIANT:=1
 endef
 
 define Package/eapol-test-openssl
diff --git a/package/network/utils/ethtool/Makefile b/package/network/utils/ethtool/Makefile
index a62c47e7e8..2086ce6a90 100644
--- a/package/network/utils/ethtool/Makefile
+++ b/package/network/utils/ethtool/Makefile
@@ -26,24 +26,25 @@ PKG_BUILD_PARALLEL:=1
 
 include $(INCLUDE_DIR)/package.mk
 
-define Package/ethtool
+define Package/ethtool/Default
   SECTION:=net
   CATEGORY:=Network
   TITLE:=Display or change ethernet card settings
   URL:=https://www.kernel.org/pub/software/network/ethtool/
+endef
+
+define Package/ethtool
+$(call Package/ethtool/Default)
   VARIANT:=tiny
-  CONFLICTS:=ethtool-full
   DEFAULT_VARIANT:=1
 endef
 
 define Package/ethtool-full
-  $(Package/ethtool)
+$(call Package/ethtool/Default)
   TITLE += (full)
   VARIANT:=full
   PROVIDES:=ethtool
   DEPENDS:=+libmnl
-  CONFLICTS:=
-  DEFAULT_VARIANT:=
 endef
 
 define Package/ethtool/description
diff --git a/package/network/utils/iw/Makefile b/package/network/utils/iw/Makefile
index d6aaa78394..a4f56c7d66 100644
--- a/package/network/utils/iw/Makefile
+++ b/package/network/utils/iw/Makefile
@@ -23,17 +23,22 @@ PKG_BUILD_FLAGS:=gc-sections lto
 
 include $(INCLUDE_DIR)/package.mk
 
-define Package/iw
+define Package/iw/Default
   SECTION:=net
   CATEGORY:=Network
   TITLE:=cfg80211 interface configuration utility
   URL:=https://wireless.kernel.org/en/latest/en/users/documentation/iw.html
   DEPENDS:= +libnl-tiny
+endef
+
+define Package/iw
+$(call Package/iw/Default)
   VARIANT:=tiny
+  DEFAULT_VARIANT:=1
 endef
 
 define Package/iw-full
-  $(Package/iw)
+$(call Package/iw/Default)
   TITLE += (full version)
   VARIANT:=full
   PROVIDES:=iw




More information about the lede-commits mailing list