[openwrt/openwrt] realtek: pcs: rtl931x: don't mess with autoneg

LEDE Commits lede-commits at lists.infradead.org
Mon Feb 16 06:43:27 PST 2026


robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/4026f8843fa44e202b79ddb1387b3f5ddb88f566

commit 4026f8843fa44e202b79ddb1387b3f5ddb88f566
Author: Jonas Jelonek <jelonek.jonas at gmail.com>
AuthorDate: Wed Feb 11 13:15:10 2026 +0000

    realtek: pcs: rtl931x: don't mess with autoneg
    
    Part of the configuration sequence for 1G operation can be identified as
    setting autonegotiation to enabled for that mode. Starting from a previous
    commit, this is being handled properly in the set_autoneg implementation.
    Thus, remove that part from the sequence which doesn't make sense there
    anymore and might just cause problems.
    
    Signed-off-by: Jonas Jelonek <jelonek.jonas at gmail.com>
    Link: https://github.com/openwrt/openwrt/pull/22013
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c b/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
index 9a1239f351..4e1cd984e6 100644
--- a/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
+++ b/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
@@ -3630,7 +3630,6 @@ static int rtpcs_931x_sds_config_fiber_1g(struct rtpcs_serdes *sds)
 {
 	rtpcs_sds_write_bits(sds, 0x43, 0x12, 15, 14, 0x0);
 
-	rtpcs_sds_write_bits(sds, 0x42, 0x0, 12, 12, 0x1);
 	rtpcs_sds_write_bits(sds, 0x42, 0x0, 6, 6, 0x1);
 	rtpcs_sds_write_bits(sds, 0x42, 0x0, 13, 13, 0x0);
 




More information about the lede-commits mailing list