[openwrt/openwrt] unetmsg: fix inverted condition in network_rx_socket_close()
LEDE Commits
lede-commits at lists.infradead.org
Mon Feb 16 00:20:58 PST 2026
nbd pushed a commit to openwrt/openwrt.git, branch openwrt-25.12:
https://git.openwrt.org/d63541ff9841853679b8ff49af72eec25aabf901
commit d63541ff9841853679b8ff49af72eec25aabf901
Author: Felix Fietkau <nbd at nbd.name>
AuthorDate: Fri Feb 6 09:30:26 2026 +0000
unetmsg: fix inverted condition in network_rx_socket_close()
The cleanup condition checked != instead of ==, inverting the logic.
This caused two problems:
When an authenticated RX connection disconnected, remote state for that
host was never cleaned up since the stored entry matched the one being
closed.
When a stale unauthenticated connection from a peer closed, any existing
authenticated connection from the same peer was incorrectly deleted and
its remote state wiped.
Signed-off-by: Felix Fietkau <nbd at nbd.name>
(cherry picked from commit f09596f84f3572d963e1c893762fd105b4ceee2e)
---
.../services/unetmsg/files/usr/share/ucode/unetmsg/unetmsgd-remote.uc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/network/services/unetmsg/files/usr/share/ucode/unetmsg/unetmsgd-remote.uc b/package/network/services/unetmsg/files/usr/share/ucode/unetmsg/unetmsgd-remote.uc
index 1f1c97a2ca..54e77596f1 100644
--- a/package/network/services/unetmsg/files/usr/share/ucode/unetmsg/unetmsgd-remote.uc
+++ b/package/network/services/unetmsg/files/usr/share/ucode/unetmsg/unetmsgd-remote.uc
@@ -62,7 +62,7 @@ function network_rx_socket_close(data)
core.dbg(`Incoming connection from ${data.name} closed\n`);
let net = networks[data.network];
- if (net && net.rx_channels[data.name] != data) {
+ if (net && net.rx_channels[data.name] == data) {
delete net.rx_channels[data.name];
network_rx_cleanup_state(data.name);
}
More information about the lede-commits
mailing list