[openwrt/openwrt] build: propagate errors when generating apk indexes

LEDE Commits lede-commits at lists.infradead.org
Fri Feb 13 12:17:24 PST 2026


robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/fcb07b00ec22b90fc0cd790701982018ee345366

commit fcb07b00ec22b90fc0cd790701982018ee345366
Author: Matt Merhar <mattmerhar at protonmail.com>
AuthorDate: Wed Feb 11 14:33:15 2026 -0500

    build: propagate errors when generating apk indexes
    
    The build would continue even if the some of the intermediate commands
    failed, as long as the last command in the final iteration of the loop
    was successful.
    
    Add 'set -e' to the subshell so that we immediately exit. Previously,
    only the exit status of the final make-index-json.py mattered.
    
    Fixes: https://github.com/openwrt/openwrt/issues/21981
    Signed-off-by: Matt Merhar <mattmerhar at protonmail.com>
    Link: https://github.com/openwrt/openwrt/pull/21993
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 package/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/Makefile b/package/Makefile
index 7e69b9a0b5..b5581f9859 100644
--- a/package/Makefile
+++ b/package/Makefile
@@ -129,6 +129,7 @@ $(curdir)/index: FORCE
 	@echo Generating package index...
 ifneq ($(CONFIG_USE_APK),)
 	@for d in $(PACKAGE_SUBDIRS); do \
+		set -e; \
 		mkdir -p $$d; \
 		cd $$d || continue; \
 		ls *.apk >/dev/null 2>&1 || continue; \




More information about the lede-commits mailing list