[openwrt/openwrt] realtek: pcs: rtl931x: drop unneeded cmu band read

LEDE Commits lede-commits at lists.infradead.org
Sat Feb 7 15:36:09 PST 2026


hauke pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/eda2d44ebd4f742e3c0cc8e41b7c5c81df80bd47

commit eda2d44ebd4f742e3c0cc8e41b7c5c81df80bd47
Author: Jonas Jelonek <jelonek.jonas at gmail.com>
AuthorDate: Tue Feb 3 18:51:49 2026 +0000

    realtek: pcs: rtl931x: drop unneeded cmu band read
    
    There is still a stray call in setup_serdes to read the current CMU
    band. The only effect is that the current band is printed to the log, the
    value itself isn't used for anything further. Drop this since it's not
    needed.
    
    Signed-off-by: Jonas Jelonek <jelonek.jonas at gmail.com>
    Link: https://github.com/openwrt/openwrt/pull/21858
    Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
---
 target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c b/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
index 6f6e740e51..e7efe04888 100644
--- a/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
+++ b/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
@@ -3340,6 +3340,7 @@ static int rtpcs_931x_sds_cmu_band_set(struct rtpcs_serdes *sds,
 	return 0;
 }
 
+__maybe_unused
 static int rtpcs_931x_sds_cmu_band_get(struct rtpcs_serdes *sds,
 				       enum rtpcs_sds_mode hw_mode)
 {
@@ -3593,7 +3594,7 @@ static int rtpcs_931x_setup_serdes(struct rtpcs_serdes *sds,
 	struct rtpcs_serdes *even_sds = rtpcs_sds_get_even(sds);
 	struct rtpcs_ctrl *ctrl = sds->ctrl;
 	u32 sds_id = sds->id;
-	u32 band, val;
+	u32 val;
 	int ret;
 
 	/*
@@ -3629,9 +3630,6 @@ static int rtpcs_931x_setup_serdes(struct rtpcs_serdes *sds,
 
 	rtpcs_931x_sds_power(sds, false);
 
-	/* TODO: is this needed? */
-	band = rtpcs_931x_sds_cmu_band_get(sds, hw_mode);
-
 	ret = rtpcs_931x_sds_config_hw_mode(sds, hw_mode);
 	if (ret < 0)
 		return ret;




More information about the lede-commits mailing list