[openwrt/openwrt] treewide: replace numbers with GPIO_ACTIVE

LEDE Commits lede-commits at lists.infradead.org
Wed Oct 8 05:26:31 PDT 2025 

robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/c186d17fa51875bbf10cd8b1fc8c066f0f1db5ff

commit c186d17fa51875bbf10cd8b1fc8c066f0f1db5ff
Author: Rosen Penev <rosenp at gmail.com>
AuthorDate: Sat Sep 20 21:11:32 2025 -0700

    treewide: replace numbers with GPIO_ACTIVE
    
    The latter is more descriptive in terms of what's going on.
    
    Mostly found with
    
    git grep gpios\  | grep 0\>
    git grep gpios\  | grep 1\>
    
    Signed-off-by: Rosen Penev <rosenp at gmail.com>
    Link: https://github.com/openwrt/openwrt/pull/20116
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 target/linux/ath79/dts/ar9344_aerohive_hiveap-121.dts               | 6 +++---
 target/linux/ath79/dts/ar9344_qihoo_c301.dts                        | 4 ++--
 target/linux/ath79/dts/ar9344_wd_mynet-n600.dts                     | 4 ++--
 target/linux/ath79/dts/ar9344_wd_mynet-n750.dts                     | 4 ++--
 target/linux/ath79/dts/qca955x_zyxel_nbg6x16.dtsi                   | 2 +-
 .../files-6.12/arch/arm/boot/dts/qcom/qcom-ipq4018-rutx.dtsi        | 4 ++--
 .../files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-onhub.dtsi        | 2 +-
 .../files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-unifi-ac-hd.dts   | 2 +-
 .../kirkwood/files/arch/arm/boot/dts/marvell/kirkwood-dns320l.dts   | 6 +++---
 .../files/arch/mips/boot/dts/lantiq/danube_arcadyan_arv452cqw.dts   | 2 +-
 target/linux/lantiq/files/arch/mips/boot/dts/lantiq/falcon.dtsi     | 3 ++-
 target/linux/mediatek/dts/mt7622-dlink-eagle-pro-ai-ax3200-a1.dtsi  | 2 +-
 target/linux/mediatek/dts/mt7622-linksys-e8450.dtsi                 | 2 +-
 target/linux/mediatek/dts/mt7629-iptime-a6004mx.dts                 | 2 +-
 target/linux/mediatek/dts/mt7629-linksys-ea7500-v3.dts              | 2 +-
 target/linux/mediatek/dts/mt7981b-asus-rt-ax52.dts                  | 2 +-
 target/linux/mediatek/dts/mt7981b-gatonetworks-gdsp.dts             | 2 +-
 .../files-6.12/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dtsi        | 5 +++--
 .../arch/mips/boot/dts/cavium-octeon/cn6130_cisco_vedge1000.dts     | 5 +++--
 19 files changed, 32 insertions(+), 29 deletions(-)

diff --git a/target/linux/ath79/dts/ar9344_aerohive_hiveap-121.dts b/target/linux/ath79/dts/ar9344_aerohive_hiveap-121.dts
index 300b3b39bf..68eb30e7ef 100644
--- a/target/linux/ath79/dts/ar9344_aerohive_hiveap-121.dts
+++ b/target/linux/ath79/dts/ar9344_aerohive_hiveap-121.dts
@@ -74,21 +74,21 @@
 
 	gpio_ext_lna0 {
 		gpio-hog;
-		gpios = <20 0>;
+		gpios = <20 GPIO_ACTIVE_HIGH>;
 		output-low;
 		line-name = "hiveap-121:ext:lna0";
 	};
 
 	gpio_ext_lna1 {
 		gpio-hog;
-		gpios = <19 0>;
+		gpios = <19 GPIO_ACTIVE_HIGH>;
 		output-low;
 		line-name = "hiveap-121:ext:lna1";
 	};
 
 	gpio_usb_power {
 		gpio-hog;
-		gpios = <15 0>;
+		gpios = <15 GPIO_ACTIVE_HIGH>;
 		output-high;
 		line-name = "hiveap-121:power:usb";
 	};
diff --git a/target/linux/ath79/dts/ar9344_qihoo_c301.dts b/target/linux/ath79/dts/ar9344_qihoo_c301.dts
index a63c8bc4d9..100bf83886 100644
--- a/target/linux/ath79/dts/ar9344_qihoo_c301.dts
+++ b/target/linux/ath79/dts/ar9344_qihoo_c301.dts
@@ -82,14 +82,14 @@
 &gpio {
 	gpio_ext_lna0 {
 		gpio-hog;
-		gpios = <14 0>;
+		gpios = <14 GPIO_ACTIVE_HIGH>;
 		output-high;
 		line-name = "c301:ext:lna0";
 	};
 
 	gpio_ext_lna1 {
 		gpio-hog;
-		gpios = <15 0>;
+		gpios = <15 GPIO_ACTIVE_HIGH>;
 		output-high;
 		line-name = "c301:ext:lna1";
 	};
diff --git a/target/linux/ath79/dts/ar9344_wd_mynet-n600.dts b/target/linux/ath79/dts/ar9344_wd_mynet-n600.dts
index c7149953be..f85924a97c 100644
--- a/target/linux/ath79/dts/ar9344_wd_mynet-n600.dts
+++ b/target/linux/ath79/dts/ar9344_wd_mynet-n600.dts
@@ -60,14 +60,14 @@
 &gpio {
 	gpio_ext_lna0 {
 		gpio-hog;
-		gpios = <14 0>;
+		gpios = <14 GPIO_ACTIVE_HIGH>;
 		output-high;
 		line-name = "ext:lna0";
 	};
 
 	gpio_ext_lna1 {
 		gpio-hog;
-		gpios = <15 0>;
+		gpios = <15 GPIO_ACTIVE_HIGH>;
 		output-high;
 		line-name = "ext:lna1";
 	};
diff --git a/target/linux/ath79/dts/ar9344_wd_mynet-n750.dts b/target/linux/ath79/dts/ar9344_wd_mynet-n750.dts
index ecc1d182d1..da3f3b3614 100644
--- a/target/linux/ath79/dts/ar9344_wd_mynet-n750.dts
+++ b/target/linux/ath79/dts/ar9344_wd_mynet-n750.dts
@@ -59,14 +59,14 @@
 &gpio {
 	gpio_ext_lna0 {
 		gpio-hog;
-		gpios = <15 0>;
+		gpios = <15 GPIO_ACTIVE_HIGH>;
 		output-high;
 		line-name = "ext:lna0";
 	};
 
 	gpio_ext_lna1 {
 		gpio-hog;
-		gpios = <18 0>;
+		gpios = <18 GPIO_ACTIVE_HIGH>;
 		output-high;
 		line-name = "ext:lna1";
 	};
diff --git a/target/linux/ath79/dts/qca955x_zyxel_nbg6x16.dtsi b/target/linux/ath79/dts/qca955x_zyxel_nbg6x16.dtsi
index 99f61afbc0..63b20b4725 100644
--- a/target/linux/ath79/dts/qca955x_zyxel_nbg6x16.dtsi
+++ b/target/linux/ath79/dts/qca955x_zyxel_nbg6x16.dtsi
@@ -36,7 +36,7 @@
 &gpio {
 	gpio_usb_power: usb_power {
 		gpio-hog;
-		gpios = <16 0>;
+		gpios = <16 GPIO_ACTIVE_HIGH>;
 		output-high;
 	};
 };
diff --git a/target/linux/ipq40xx/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq4018-rutx.dtsi b/target/linux/ipq40xx/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq4018-rutx.dtsi
index cf59ff68fe..cc43e222e4 100644
--- a/target/linux/ipq40xx/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq4018-rutx.dtsi
+++ b/target/linux/ipq40xx/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq4018-rutx.dtsi
@@ -52,7 +52,7 @@
 
 			reset {
 				label = "reset";
-				gpios = <&tlmm 4 1>;
+				gpios = <&tlmm 4 GPIO_ACTIVE_LOW>;
 				linux,code = <KEY_RESTART>;
 			};
 		};
@@ -141,7 +141,7 @@
 &blsp1_spi1 {
 	pinctrl-0 = <&spi_0_pins>;
 	pinctrl-names = "default";
-	cs-gpios = <&tlmm 54 0>, <&tlmm 63 0>;
+	cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>, <&tlmm 63 GPIO_ACTIVE_HIGH>;
 	num-cs = <2>;
 	status = "okay";
 
diff --git a/target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-onhub.dtsi b/target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-onhub.dtsi
index 5b8de27ad6..2010c4f7b8 100644
--- a/target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-onhub.dtsi
+++ b/target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-onhub.dtsi
@@ -405,7 +405,7 @@
 		pinctrl-0 = <&spi_pins>;
 		pinctrl-names = "default";
 
-		cs-gpios = <&qcom_pinmux 20 0>;
+		cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
 
 		flash: flash at 0 {
 			compatible = "jedec,spi-nor";
diff --git a/target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-unifi-ac-hd.dts b/target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-unifi-ac-hd.dts
index 3a1ad07ecd..a1717a999b 100644
--- a/target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-unifi-ac-hd.dts
+++ b/target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-unifi-ac-hd.dts
@@ -100,7 +100,7 @@
 
 		pinctrl-0 = <&spi_pins>;
 		pinctrl-names = "default";
-		cs-gpios = <&qcom_pinmux 20 0>;
+		cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
 
 		flash at 0 {
 			compatible = "mx25u25635f", "jedec,spi-nor";
diff --git a/target/linux/kirkwood/files/arch/arm/boot/dts/marvell/kirkwood-dns320l.dts b/target/linux/kirkwood/files/arch/arm/boot/dts/marvell/kirkwood-dns320l.dts
index cc2b3d0cd4..68afdbe468 100644
--- a/target/linux/kirkwood/files/arch/arm/boot/dts/marvell/kirkwood-dns320l.dts
+++ b/target/linux/kirkwood/files/arch/arm/boot/dts/marvell/kirkwood-dns320l.dts
@@ -57,13 +57,13 @@
 		button at 1 {
 			label = "Reset push button";
 			linux,code = <KEY_RESTART>;
-			gpios = <&gpio0 28 1>;
+			gpios = <&gpio0 28 GPIO_ACTIVE_LOW>;
 		};
 
 		button at 2 {
 			label = "USB unmount button";
 			linux,code = <KEY_EJECTCD>;
-			gpios = <&gpio0 27 1>;
+			gpios = <&gpio0 27 GPIO_ACTIVE_LOW>;
 		};
 	};
 
@@ -127,7 +127,7 @@
 			enable-active-high;
 			regulator-always-on;
 			regulator-boot-on;
-			gpios = <&gpio0 24 0>;
+			gpios = <&gpio0 24 GPIO_ACTIVE_HIGH>;
 		};
 	};
 };
diff --git a/target/linux/lantiq/files/arch/mips/boot/dts/lantiq/danube_arcadyan_arv452cqw.dts b/target/linux/lantiq/files/arch/mips/boot/dts/lantiq/danube_arcadyan_arv452cqw.dts
index 42c50e1e82..b68fbf1d94 100644
--- a/target/linux/lantiq/files/arch/mips/boot/dts/lantiq/danube_arcadyan_arv452cqw.dts
+++ b/target/linux/lantiq/files/arch/mips/boot/dts/lantiq/danube_arcadyan_arv452cqw.dts
@@ -105,7 +105,7 @@
 		};
 		voice {
 			label = "blue:sprache";
-			gpios = <&gpiomm 4 1>;
+			gpios = <&gpiomm 4 GPIO_ACTIVE_LOW>;
 		};
 		led_usb: usb {
 			function = LED_FUNCTION_USB;
diff --git a/target/linux/lantiq/files/arch/mips/boot/dts/lantiq/falcon.dtsi b/target/linux/lantiq/files/arch/mips/boot/dts/lantiq/falcon.dtsi
index 2f5557c0c7..5705e519f8 100644
--- a/target/linux/lantiq/files/arch/mips/boot/dts/lantiq/falcon.dtsi
+++ b/target/linux/lantiq/files/arch/mips/boot/dts/lantiq/falcon.dtsi
@@ -172,7 +172,8 @@
 			reg = <0x200000 0x10000>;
 			interrupt-parent = <&icu0>;
 			interrupts = <18 19 20 21>;
-			gpios = <&gpio1 7 0 &gpio1 8 0>;
+			gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>,
+				<&gpio1 8 GPIO_ACTIVE_HIGH>;
 			pinctrl-names = "default";
 			pinctrl-0 = <&i2c_pins>;
 			clocks = <&clock_sys1 14>;
diff --git a/target/linux/mediatek/dts/mt7622-dlink-eagle-pro-ai-ax3200-a1.dtsi b/target/linux/mediatek/dts/mt7622-dlink-eagle-pro-ai-ax3200-a1.dtsi
index ae92fedc58..4762994617 100644
--- a/target/linux/mediatek/dts/mt7622-dlink-eagle-pro-ai-ax3200-a1.dtsi
+++ b/target/linux/mediatek/dts/mt7622-dlink-eagle-pro-ai-ax3200-a1.dtsi
@@ -84,7 +84,7 @@
 			#interrupt-cells = <1>;
 			interrupt-parent = <&pio>;
 			interrupts = <53 IRQ_TYPE_LEVEL_HIGH>;
-			reset-gpios = <&pio 54 0>;
+			reset-gpios = <&pio 54 GPIO_ACTIVE_HIGH>;
 
 			ports {
 				#address-cells = <1>;
diff --git a/target/linux/mediatek/dts/mt7622-linksys-e8450.dtsi b/target/linux/mediatek/dts/mt7622-linksys-e8450.dtsi
index 882ab841a7..7e9de8a790 100644
--- a/target/linux/mediatek/dts/mt7622-linksys-e8450.dtsi
+++ b/target/linux/mediatek/dts/mt7622-linksys-e8450.dtsi
@@ -146,7 +146,7 @@
 			#interrupt-cells = <1>;
 			interrupt-parent = <&pio>;
 			interrupts = <53 IRQ_TYPE_LEVEL_HIGH>;
-			reset-gpios = <&pio 54 0>;
+			reset-gpios = <&pio 54 GPIO_ACTIVE_HIGH>;
 
 			ports {
 				#address-cells = <1>;
diff --git a/target/linux/mediatek/dts/mt7629-iptime-a6004mx.dts b/target/linux/mediatek/dts/mt7629-iptime-a6004mx.dts
index 7a3fa4deff..aabf6e6dc1 100644
--- a/target/linux/mediatek/dts/mt7629-iptime-a6004mx.dts
+++ b/target/linux/mediatek/dts/mt7629-iptime-a6004mx.dts
@@ -130,7 +130,7 @@
 		switch at 1f {
 			compatible = "mediatek,mt7531";
 			reg = <31>;
-			reset-gpios = <&pio 28 0>;
+			reset-gpios = <&pio 28 GPIO_ACTIVE_HIGH>;
 			interrupt-controller;
 			#interrupt-cells = <1>;
 			interrupt-parent = <&pio>;
diff --git a/target/linux/mediatek/dts/mt7629-linksys-ea7500-v3.dts b/target/linux/mediatek/dts/mt7629-linksys-ea7500-v3.dts
index 70b7cde6d9..7c9b9a3d37 100644
--- a/target/linux/mediatek/dts/mt7629-linksys-ea7500-v3.dts
+++ b/target/linux/mediatek/dts/mt7629-linksys-ea7500-v3.dts
@@ -108,7 +108,7 @@
 		switch at 1f {
 			compatible = "mediatek,mt7531";
 			reg = <31>;
-			reset-gpios = <&pio 28 0>;
+			reset-gpios = <&pio 28 GPIO_ACTIVE_HIGH>;
 			interrupt-controller;
 			#interrupt-cells = <1>;
 			interrupt-parent = <&pio>;
diff --git a/target/linux/mediatek/dts/mt7981b-asus-rt-ax52.dts b/target/linux/mediatek/dts/mt7981b-asus-rt-ax52.dts
index 604d318eae..c0e995fb9f 100644
--- a/target/linux/mediatek/dts/mt7981b-asus-rt-ax52.dts
+++ b/target/linux/mediatek/dts/mt7981b-asus-rt-ax52.dts
@@ -122,7 +122,7 @@
 		switch at 1f {
 			compatible = "mediatek,mt7531";
 			reg = <31>;
-			reset-gpios = <&pio 39 0>;
+			reset-gpios = <&pio 39 GPIO_ACTIVE_HIGH>;
 
 			ports {
 				#address-cells = <1>;
diff --git a/target/linux/mediatek/dts/mt7981b-gatonetworks-gdsp.dts b/target/linux/mediatek/dts/mt7981b-gatonetworks-gdsp.dts
index fd08f724b5..1c1262c040 100644
--- a/target/linux/mediatek/dts/mt7981b-gatonetworks-gdsp.dts
+++ b/target/linux/mediatek/dts/mt7981b-gatonetworks-gdsp.dts
@@ -170,7 +170,7 @@
 		switch at 1f {
 			compatible = "mediatek,mt7531";
 			reg = <31>;
-			reset-gpios = <&pio 39 0>;
+			reset-gpios = <&pio 39 GPIO_ACTIVE_HIGH>;
 			interrupt-controller;
 			#interrupt-cells = <1>;
 			interrupt-parent = <&pio>;
diff --git a/target/linux/mediatek/files-6.12/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dtsi b/target/linux/mediatek/files-6.12/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dtsi
index 4eb512f90b..3c66ac9113 100644
--- a/target/linux/mediatek/files-6.12/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dtsi
+++ b/target/linux/mediatek/files-6.12/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dtsi
@@ -5,6 +5,7 @@
  */
 
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/pinctrl/mt65xx.h>
 #include "mt7986a.dtsi"
 
@@ -92,7 +93,7 @@
 		compatible = "ethernet-phy-id67c9.de0a";
 		reg = <5>;
 
-		reset-gpios = <&pio 6 1>;
+		reset-gpios = <&pio 6 GPIO_ACTIVE_LOW>;
 		reset-deassert-us = <20000>;
 	};
 
@@ -104,7 +105,7 @@
 	switch: switch at 1f {
 		compatible = "mediatek,mt7531";
 		reg = <31>;
-		reset-gpios = <&pio 5 0>;
+		reset-gpios = <&pio 5 GPIO_ACTIVE_HIGH>;
 	};
 };
 
diff --git a/target/linux/octeon/files/arch/mips/boot/dts/cavium-octeon/cn6130_cisco_vedge1000.dts b/target/linux/octeon/files/arch/mips/boot/dts/cavium-octeon/cn6130_cisco_vedge1000.dts
index 4680d6ea14..bb579ec9b6 100644
--- a/target/linux/octeon/files/arch/mips/boot/dts/cavium-octeon/cn6130_cisco_vedge1000.dts
+++ b/target/linux/octeon/files/arch/mips/boot/dts/cavium-octeon/cn6130_cisco_vedge1000.dts
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-or-later OR MIT
 
 /include/ "octeon_3xxx.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	compatible = "cisco,vedge1000", "cavium,cn6130";
@@ -168,8 +169,8 @@
 				reg = <0x00>;
 				voltage-ranges = <0xce4 0xce4>;
 				max-frequency = <0x3197500>;
-				wp-gpios = <&gpio 0x02 0x00>;
-				cd-gpios = <&gpio 0x03 0x01>;
+				wp-gpios = <&gpio 0x02 GPIO_ACTIVE_HIGH>;
+				cd-gpios = <&gpio 0x03 GPIO_ACTIVE_LOW>;
 				cavium,bus-max-width = <0x04>;
 			};
 		};

More information about the lede-commits mailing list