[openwrt/openwrt] wifi-scripts: ucode: fix wifi-vlan "network" option not working

LEDE Commits lede-commits at lists.infradead.org
Tue Nov 25 02:44:32 PST 2025


robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/63c146a464da4fe72a4eb82ad6fe6da826a5dd43

commit 63c146a464da4fe72a4eb82ad6fe6da826a5dd43
Author: Rany Hany <rany_hany at riseup.net>
AuthorDate: Mon Nov 24 15:00:57 2025 +0000

    wifi-scripts: ucode: fix wifi-vlan "network" option not working
    
    The call to netifd.set_vlan(...) had an incorrect argument
    order. It should be (interface, ifname, vlan) not
    (interface, vlan, ifname). This prevented wifi-vlan's
    "network" option from working as netifd was not able
    to find the wifi-vlan section.
    
    Fixes: https://github.com/openwrt/openwrt/issues/20705
    Fixes: https://github.com/openwrt/openwrt/issues/20911
    Signed-off-by: Rany Hany <rany_hany at riseup.net>
    Link: https://github.com/openwrt/openwrt/pull/20918
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 .../network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc b/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc
index 1f1e27dbee..00aff02661 100644
--- a/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc
+++ b/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc
@@ -288,7 +288,7 @@ function iface_vlan(interface, config, vlans) {
 		if (vlan.config.name && vlan.config.vid) {
 			let ifname = `${config.ifname}-${vlan.config.name}`;
 			file.write(`${vlan.config.vid} ${ifname}\n`);
-			netifd.set_vlan(interface, k, ifname);
+			netifd.set_vlan(interface, ifname, k);
 		}
 	file.close();
 




More information about the lede-commits mailing list