[openwrt/openwrt] realtek: pcs: Drop return on end of void functions
LEDE Commits
lede-commits at lists.infradead.org
Mon Nov 24 15:29:58 PST 2025
hauke pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/230d9363949414154ff798d61cbd14cf65b5b0c9
commit 230d9363949414154ff798d61cbd14cf65b5b0c9
Author: Sven Eckelmann <sven at narfation.org>
AuthorDate: Sun Nov 23 14:54:27 2025 +0100
realtek: pcs: Drop return on end of void functions
There is nothing to return from a void function. And it doesn't change the
execution flow. The return at the end of a void function is therefore just
a NOP.
Signed-off-by: Sven Eckelmann <sven at narfation.org>
Link: https://github.com/openwrt/openwrt/pull/20906
Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
---
target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c b/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
index c794d21958..ecf43e3f73 100644
--- a/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
+++ b/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
@@ -1993,8 +1993,6 @@ static void rtpcs_931x_sds_symerr_clear(struct rtpcs_ctrl *ctrl, u32 sds,
default:
break;
}
-
- return;
}
__attribute__((unused))
@@ -2043,8 +2041,6 @@ static void rtpcs_931x_sds_fiber_mode_set(struct rtpcs_ctrl *ctrl, u32 sds,
pr_info("%s writing analog SerDes Mode value %02x\n", __func__, val);
rtpcs_sds_write_bits(ctrl, sds, 0x1F, 0x9, 11, 6, val);
-
- return;
}
static int rtpcs_931x_sds_cmu_page_get(phy_interface_t mode)
@@ -2157,7 +2153,6 @@ static void rtpcs_931x_sds_cmu_type_set(struct rtpcs_ctrl *ctrl, u32 sds,
}
pr_info("%s CMU page 0x28 0x7 %08x\n", __func__, rtpcs_sds_read(ctrl, sds, 0x28, 0x7));
- return;
}
static void rtpcs_931x_sds_rx_reset(struct rtpcs_ctrl *ctrl, u32 sds)
More information about the lede-commits
mailing list